On Oct 13, 2010, at 2:06 PM, Cory Fields wrote: > On Wed, Oct 13, 2010 at 2:00 PM, jingai <[email protected]> wrote: >> Name: iPhoto >> addon: plugin.image.iphoto >> version: 0.9.9 >> url: git://github.com/jingai/plugin.image.iphoto.git >> branch: master >> revision: HEAD (7fe20ba85fbb0b520d7158fb0e365eb949244e7d) >> >> commit 7fe20ba85fbb0b520d7158fb0e365eb949244e7d >> Author: jingai <[email protected]> >> Date: Wed Oct 13 13:57:09 2010 -0400 >> >> Version 0.9.9. >> >> commit bdd72d17e0b8d759b6ff245d48813fcc7b3b6e1d >> Author: jingai <[email protected]> >> Date: Tue Oct 12 22:03:26 2010 -0400 >> >> Ignore unicode in thumbnails if XBMC rev < 34717. >> >> commit b297700faaba75b2315c153eea805c4652c30e81 >> Author: jingai <[email protected]> >> Date: Tue Oct 12 13:40:39 2010 -0400 >> >> Ignore unicode thumbnail paths. >> >> XBMC requires a string for thumbnail paths. >> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> Xbmc-addons mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> > > Please don't submit pull requests that require features that aren't in > that particular version. 34717 hasn't made it to Dharma branch yet.
I know, but this revision also works around the lack of the feature in Dharma. It will simply ignore unicode thumbnail paths. Without this patch, international users with Dharma can't use my plugin at all. -Jonathan ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
