Will do. I gave users 5 days to find the errors and I only updated with
fixes. Let's go ahead and wait a couple more days just to be certain there
are no more issues. I'll submit another pull request in a couple of days.
On Tue, Oct 19, 2010 at 12:18 AM, Cory Fields <[email protected]> wrote:
> On Mon, Oct 18, 2010 at 8:43 PM, Chase Williams
> <[email protected]> wrote:
> > How about a pull now?
> >
> >>> > *addon - skin.shade
> >>> > *version - 1.1.1
> >>> > *url - git://github.com/wizardxbmcmods/Shade---XBMC.git
> >>> > *revision - 941d1525
> >>> > *branch - master
> >>> > *xbmc version - dharma, eden-pre
> >
> >
> > On Wed, Oct 13, 2010 at 11:04 AM, Chase Williams <
> [email protected]>
> > wrote:
> >>
> >> Understood. I have fixed all of these errors now. I validated and
> >> applied "pretty text".
> >> I will wait a couple of days for people to find bugs, then submit again.
> >>
> >>
> >> Wiz
> >>
> >> On Wed, Oct 13, 2010 at 10:28 AM, Cory Fields <[email protected]> wrote:
> >>>
> >>> On Wed, Oct 13, 2010 at 11:17 AM, Chase Williams
> >>> <[email protected]> wrote:
> >>> > I added an exclude for thumbs.db, not sure how one made it through.
> >>> >
> >>> > What do you mean by "nested comments not allowed"?
> >>> >
> >>> > On Wed, Oct 13, 2010 at 10:05 AM, Cory Fields <[email protected]>
> wrote:
> >>> >>
> >>> >> On Wed, Oct 13, 2010 at 10:43 AM, Chase Williams
> >>> >> <[email protected]> wrote:
> >>> >> > *addon - skin.shade
> >>> >> > *version - 1.1.1
> >>> >> > *url - git://github.com/wizardxbmcmods/Shade---XBMC.git
> >>> >> > *revision - f034b8ee
> >>> >> >
> >>> >> > *branch - master
> >>> >> > *xbmc version - dharma, eden-pre
> >>> >> >
> >>> >> >
> >>> >> >
> >>> >> >
> ------------------------------------------------------------------------------
> >>> >> > Beautiful is writing same markup. Internet Explorer 9 supports
> >>> >> > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> >>> >> > Spend less time writing and rewriting code and more time creating
> >>> >> > great
> >>> >> > experiences on the web. Be a part of the beta today.
> >>> >> > http://p.sf.net/sfu/beautyoftheweb
> >>> >> > _______________________________________________
> >>> >> > Xbmc-addons mailing list
> >>> >> > [email protected]
> >>> >> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
> >>> >> >
> >>> >> >
> >>> >>
> >>> >> A few problems.
> >>> >>
> >>> >> 1. Please delete skin.shade/media/Shade/dark flags/Thumbs.db
> >>> >> 2. Lots of xml errors (nested comments not allowed). See below.
> >>> >> 3. Please fix these up and let the skin sit for a week or so to be
> >>> >> used by your early testers (see the skin update frequency thread on
> >>> >> this list for discussion).
> >>> >>
> >>> >> Thanks,
> >>> >> Cory
> >>> >>
> >>> >> skin.shade/720p/Startup.xml:43: parser error : xmlParseEntityRef: no
> >>> >> name
> >>> >>
> >>> >>
> >>> >>
> >>> >>
> <onfocus>XBMC.RunScript(script.tv.show.next.aired,silent=true&;alarm=99)</onf
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:37: parser error : Comment not
> >>> >> terminated
> >>> >> <!--<animation effect="fade" start="100" end="30" time
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:49: parser error : Comment not
> >>> >> terminated
> >>> >> <!--<animation effect="fade" start="100" end="30" time
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:359: parser error : Comment not
> >>> >> terminated
> >>> >> <!--<animation effect="fade" start="100" end="30" time
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:683: parser error : Comment not
> >>> >> terminated
> >>> >> <!--<animation effect="fade" start="100" end="30" time
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1006: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<animation effect="fade" start="100" end="30" time
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1038: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<control type="list" id="9003">
> >>> >> <posx>10</pos
> >>> >>
> >>> >> <!--<control type="label">
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1058: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<control type="image">
> >>> >>
> >>> >> <posx>50</posx>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1071: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8">ThumbShadow.png</bordert
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1083: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8">ThumbShadow.png</bordert
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1096: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- <bordertexture border="8"></bordertexture>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1103: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- <bordertexture border="8"></bordertexture>
> >>> >>
> >>> >> <!--<control
> >>> >> type="label">
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1123: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<control type="image">
> >>> >>
> >>> >> <posx>50</posx>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1136: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8"></bordertexture>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1148: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8"></bordertexture>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1161: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<animation effect="zoom" start="100" end="110" cen
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1209: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8">ThumbShadow.png</bordert
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1219: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- </control>
> >>> >>
> >>> >> <control type="image">
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1221: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- </control>
> >>> >>
> >>> >> <control type="image">
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1235: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--</control>
> >>> >>
> >>> >> <control type="image">
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1254: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--</control>
> >>> >> <include>VisibleFadeEffect</include
> >>> >>
> >>> >> <!--<control type="label">
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1274: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<control type="image">
> >>> >>
> >>> >> <posx>50</posx>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1286: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- <bordertexture border="8">ThumbShadow.png</border
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1298: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- <bordertexture border="8">ThumbShadow.png</border
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1311: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- </control>
> >>> >>
> >>> >> <control type="image">
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1318: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!-- <bordertexture border="8"></bordertexture>
> >>> >>
> >>> >> <!--<control
> >>> >> type="label">
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1338: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<control type="image">
> >>> >>
> >>> >> <posx>50</posx>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1351: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8"></bordertexture>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1363: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<bordertexture border="8"></bordertexture>
> >>> >>
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_Home_1112.xml:1377: parser error : Comment
> not
> >>> >> terminated
> >>> >> <!--<animation effect="zoom" start="100" end="110" cen
> >>> >>
> >>> >> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> >> condition="C
> >>> >>
> >>> >> ^
> >>> >> skin.shade/720p/custom_WhatsOnTv_1116.xml:586: parser error :
> Comment
> >>> >> must not contain '--' (double-hyphen)
> >>> >> <!--<item id="3">
> >>> >
> >>> >
> >>>
> >>> Please remember to reply all.
> >>>
> >>> thumbs.db != Thumbs.db
> >>>
> >>> Comments within comments like this one are not allowed in xml:
> >>>
> >>> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> condition="Control.HasFocus(9002)">Conditional</animation>
> >>> <animation effect="fade" start="100" end="30" time="0"
> >>> condition="Control.HasFocus(9001)">Conditional</animation>
> >>> <!--<animation effect="fade" start="100" end="30" time="0"
> >>> condition="Control.HasFocus(9000)">Conditional</animation>
> >>> <animation effect="fade" start="100" end="30" time="0"
> >>> condition="Control.HasFocus(8011)">Conditional</animation>-->
> >>>
> >>> It would be great if you would validate all of your xml before
> >>> submitting pull requests.
> >>>
> >>> Cory
> >>
> >
> >
>
> I think maybe we're not on the same page here.
>
> The reason that I ask for changes to sit for a few days is so that
> problems can be discovered and fixed in the meantime. The filenames,
> for example, were a _huge_ issue that would've been merged in if I had
> pulled the revision you requested.
>
> So rather than having untested/unverified changes going into the repo,
> I ask that you let users test for a week or so. If all looks good, we
> commit _that_ revision to the repo. Things were looking good, and
> users were testing... then you committed more changes.
>
> If you would like to keep working while you're letting users test a
> certain version, please use git tags or branches.
>
> The changes seem pretty minor, so I'll let it slide this time. But
> please keep in mind that in the future, only well-tested pull requests
> will be accepted. So be specific with the branch/tag/revision you
> would like me to pull.
>
> With all that said... Please change the & to & on Startup.xml,
> line 43. Then I'll pull.
>
> Cory
>
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
