Doh! There´s always something. Removed that as well, hopefully should be
fine now.
Regards,
Arne
On Fri, Oct 22, 2010 at 5:56 PM, Olympia <[email protected]> wrote:
> Very nice!
>
> Only the last bit is missing, namely that you haven't removed the the
> unnecessary parts from disneyinfo.xml header:
> name="disneyinfo.nl" content="movies" language="nl"
>
> Cheers,
> Bence
>
>
> On Fri, Oct 22, 2010 at 4:32 PM, Arne Bultman <[email protected]> wrote:
>
>> Done, done, done and done.
>>
>> I've also changed the lookup for thumbs to use TMDB and removed the
>> dependency to the movieposterdb.
>>
>> let me know if you have any further comments.
>>
>> Arne
>>
>>
>> On Fri, Oct 22, 2010 at 3:06 PM, Olympia <[email protected]> wrote:
>>
>>> Hello Arne,
>>>
>>> Thank you for your submission!
>>>
>>> In order to approve it to the official repo, could you please make the
>>> following changes:
>>> - in addon.xml you import imdb scraper library, but you're not using it,
>>> please remove
>>> - you have to use "chain function" calls to tmdb and movieposterdb,
>>> because the way you're doing will be depreciated soon. Please have a look on
>>> how other scrapers (eg. IMDb) do it - very easy change actually
>>> - from disneyinfo.xml please remove the includes and the getsettings
>>> section and also the unnecessary tags (name, content, language) from the
>>> header. All these are now in addon.xml
>>> - please change the scraper framework to 1.1 instead of 11
>>>
>>> Cheers,
>>> Bence
>>>
>>> On Fri, Oct 22, 2010 at 12:17 PM, Arne Bultman <[email protected]> wrote:
>>>
>>>> *addon - metadata.disneyinfo.nl
>>>> *version - 1.0.0
>>>> *url -http://www.bultsblog.com/subversion/DisneyInfoScraper
>>>> *revision - HEAD
>>>> *branch - trunk
>>>> *xbmc version - dharma, eden-pre
>>>>
>>>> Thanks,
>>>> Arne Bultman.
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Nokia and AT&T present the 2010 Calling All Innovators-North America
>>>> contest
>>>> Create new apps & games for the Nokia N8 for consumers in U.S. and
>>>> Canada
>>>> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in
>>>> marketing
>>>> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
>>>> http://p.sf.net/sfu/nokia-dev2dev
>>>> _______________________________________________
>>>> Xbmc-addons mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>
>>>>
>>>
>>
>>
>> --
>> “Build a man a fire, and he'll be warm for a day. Set a man on fire, and
>> he'll be warm for the rest of his life.”
>>
>>
>> ------------------------------------------------------------------------------
>> Nokia and AT&T present the 2010 Calling All Innovators-North America
>> contest
>> Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
>> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in
>> marketing
>> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
>> http://p.sf.net/sfu/nokia-dev2dev
>> _______________________________________________
>> Xbmc-addons mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>>
>
--
“Build a man a fire, and he'll be warm for a day. Set a man on fire, and
he'll be warm for the rest of his life.”
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
