On Mon, Nov 8, 2010 at 11:37 AM, Thomas Amland <[email protected]> wrote:
> *addon - plugin.video.nrk
> *version - 2.0.0
> *url - git://github.com/takoi/xbmc-nrk-addon.git

first of all; YAY! been waiting for this one :)

then there's some issues.

1) please use unix eol's in addon.xml at the very least - see attached
2) please rename LICENSE to LICENSE.txt - consistency.
3) need an icon - freezy made a very nice one earlier (from previous
add-on, attaching to feed your lazyness).
4) need description etc.i would suggest using the ones from the
original addon.xml (attaching ^^).
4) English language must be added
5) language file has mixed eol's - decide on one (unix preferred)
6) we already have a script module for beautiful soup. use

<import addon="script.module.beautifulsoup"> in addon.xml and remove
the copy in your tree.

cheers

arnem
diff --git a/addon.xml b/addon.xml
index 5232519..e0be7d8 100644
--- a/addon.xml
+++ b/addon.xml
@@ -1,17 +1,17 @@
-<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<addon id="plugin.video.nrk"
-       name="NRK"
-       version="2.0.0"
-       provider-name="takoi">
-  <requires>
-    <import addon="xbmc.python" version="1.0"/>
-  </requires>
-  <extension point="xbmc.python.pluginsource" library="default.py">
-    <provides>video</provides>
-  </extension>
-  <extension point="xbmc.addon.metadata">
-    <platform>all</platform>
-    <summary lang="en"></summary>
-    <description lang="en"></description>
-  </extension>
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<addon id="plugin.video.nrk"
+       name="NRK"
+       version="2.0.0"
+       provider-name="takoi">
+  <requires>
+    <import addon="xbmc.python" version="1.0"/>
+  </requires>
+  <extension point="xbmc.python.pluginsource" library="default.py">
+    <provides>video</provides>
+  </extension>
+  <extension point="xbmc.addon.metadata">
+    <platform>all</platform>
+    <summary lang="en"></summary>
+    <description lang="en"></description>
+  </extension>
 </addon>

<<attachment: icon.png>>

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="plugin.video.nrk"
       name="NRK"
       version="0.9.7" 
       provider-name="VictorV">
  <requires>
    <import addon="xbmc.python" version="1.0"/>
  </requires>
  <extension point="xbmc.python.pluginsource"
            library="default.py">
        <provides>video</provides>
  </extension>
  <extension point="xbmc.addon.metadata">
    <platform>all</platform>
    <summary lang="en">NRK</summary>
    <summary lang="hu">NRK média kiegészítõ</summary> 
    <description lang="en">Watch shows, documentaries, sports, liveTV and news from NRK.no</description>
    <description lang="hu">A kiegészítõ célja, hogy médiaanyagot olvasson be a www.nrk.no wehelyrõl és virtuális könyvtárakat képezzen ezek segítségével.</description>
    <broken>Site changes</broken>
  </extension>
</addon>
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to