On Thu, Dec 2, 2010 at 2:56 PM, tvalacarta <[email protected]> wrote:
> Ok, i have no problem.
>
> Take into account that since the megavideo change many videos doesn't work.
>
> Many users want this update :)

sorry this took so long, been busy with my dissertation and the
necessary relaxation after it.

a few comments;

1) managing favorites.xml is NOT something an add-on should do - in
particular not using regexp for writing xml (parsing is dirty, writing
is outright a nono. you can do whatever you want to your own files
ofc). this is a deal breaker and there's absolutely no way i'd ever
accept it.

2) don't write to the global userdata folder - use
getAddonInfo("profile") to get to your add-on's writable directory.
for instance there's no guarantee you're running as the master user.

3) why are you using the old runplugin(plugins://video/pelisalacarta
..) ? should be runplugin(plugin.video.pelisalacarta)

4) don't use os.getcwd - use getAddonInfo("path"). os.getcwd will
break soon when we ditch the internal python

maintaining this code must be a major pita - i have spent over 1h just
reviewing the changes...

------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to