I still have a problem with it :(

"cache_file = "%s%s" % (path,'icecast.cache')"  should  be "cache_file =
os.path.join(path,'icecast.cache')" as I am not sure how that would
translate cross platform.

and

>   try: os.mkdir(path)
>
>   except: OSError
>
>
is better as

    if  not os.path.exists(path):

      os.makedirs(path)




you can also "speed it up" by specifying cache_file only once below
the BASE_URL as there is no need to do it twice in two different defs.

sorry, I am not picking on you or the code, I am just making sure we
minimize any potential errors.

Cheers,
Zeljko


On Sun, Dec 26, 2010 at 10:06 PM, Assen Totin <[email protected]> wrote:

> *addon - plugin.audio.icecast
> *version - 0.0.4
> *url - svn://svn.online.bg/plugin.audio.icecast/
> *revision - 8
> *branch - TRUNK
> *xbmc version - dharma, eden-pre
>
> Changes since 0.0.3:
>
> - Moved the cache file outside the add-on directory into the
> userdata/addon_data/<id> (better complies with XBMC requirements and
> also fixes errors on read-only addon directories - e.g., on
> system-wide installation)
>
> - Fixed an outstanding reference to shoutcast in __settings__
>
> WWell,
>
> Assen Totin
>
>
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to