Done! -------------------------------------------------- From: "Cory Fields" <[email protected]> Sent: Sunday, February 20, 2011 8:20 AM To: "Olov Nilzén" <[email protected]> Cc: "Wizard" <[email protected]>; <[email protected]> Subject: Re: [Xbmc-addons] [Git Pull] [skin.simplicity] Initial pull request
> On Sun, Feb 20, 2011 at 5:11 AM, Olov Nilzén <[email protected]> wrote: >> There seems to be an misspelling somewhere, xbmc is requesting the >> url >> http://mirrors.xbmc.org/addons/dharma/skin.simplicty/skin.simplicty-1.0.3.zip.md5 >> But the url on the server is: >> http://mirrors.xbmc.org/addons/dharma/skin.simplicity/skin.simplicty-1.0.3.zip.md5 >> /Olov >> On Thu, Feb 17, 2011 at 7:05 PM, Cory Fields <[email protected]> wrote: >>> >>> On Tue, Feb 15, 2011 at 12:25 AM, Wizard <[email protected]> >>> wrote: >>> > Correction: Forget to do a -u. :) >>> > >>> > *Name: Simplicity >>> > *addon: skin.simplicity >>> > *version: 1.0.3 >>> > *url: git://github.com/wizardxbmcmods/simplicity-xbmc >>> > *revision - ac1e4d1e >>> > *branch - master >>> > *xbmc version - dharma >>> > >>> > -------------------------------------------------- >>> > From: "Cory Fields" <[email protected]> >>> > Sent: Monday, February 14, 2011 10:52 PM >>> > To: "Wizard" <[email protected]> >>> > Cc: <[email protected]> >>> > Subject: Re: [Xbmc-addons] [Git Pull] [skin.simplicity] Initial pull >>> > request >>> > >>> >> On Mon, Feb 14, 2011 at 11:08 PM, Wizard <[email protected]> >>> >> wrote: >>> >>> >>> >>> *Name: Simplicity >>> >>> *addon: skin.simplicity >>> >>> *version: 1.0.2 >>> >>> *url: git://github.com/wizardxbmcmods/simplicity-xbmc >>> >>> *revision - 32937652 >>> >>> *branch - master >>> >>> *xbmc version - dharma >>> >>> >>> >>> >>> >>> -------------------------------------------------------------------------------------- >>> >>> >>> >>> Requesting an initial pull. Thanks! >>> >>> >>> >>> -Wiz >>> >>> >>> >>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> The ultimate all-in-one performance toolkit: Intel(R) Parallel >>> >>> Studio >>> >>> XE: >>> >>> Pinpoint memory and threading errors before they happen. >>> >>> Find and fix more than 250 security defects in the development >>> >>> cycle. >>> >>> Locate bottlenecks in serial and parallel code that limit >>> >>> performance. >>> >>> http://p.sf.net/sfu/intel-dev2devfeb >>> >>> _______________________________________________ >>> >>> Xbmc-addons mailing list >>> >>> [email protected] >>> >>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >>> >>> >>> >>> >>> >> >>> >> Thanks for the submission, looks very nice. >>> >> >>> >> 1. Please move the theme stuff to a folder called themes/ in the root >>> >> dir. See alaska for an example. They must _not_ be xbt'd. This is the >>> >> only way our packager will include the themes correctly. >>> >> 2. skin.simplicity/720p/Startup.xml line 43: &alarm -> &alarm >>> >> >>> >> Nice work, I really don't have much else to complain about :) Once >>> >> those are fixed up I'll pull. >>> >> >>> >> Cory >>> >> >>> > >>> >>> Looks good, I'll pull aad9bcf. Thanks for fixing the version, I hadn't >>> noticed. As a side-note, why do you delete/recreate files in separate >>> commits? That defeats the purpose ;). It also makes review almost >>> impossible. >>> >>> Cory >>> >>> >>> ------------------------------------------------------------------------------ >>> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio >>> XE: >>> Pinpoint memory and threading errors before they happen. >>> Find and fix more than 250 security defects in the development cycle. >>> Locate bottlenecks in serial and parallel code that limit performance. >>> http://p.sf.net/sfu/intel-dev2devfeb >>> _______________________________________________ >>> Xbmc-addons mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> >> > > Grr.. > > I was so happy to see that igotdvds fixed his addon id that i didn't > verify it. > > Igotdvds: I'm going to fix your addon.xml and bump to 1.0.4. Please do > the same in your repo. > > Cory > ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
