Ok, looks all good to me. Thanks for the good quick work! Please specify a revision to pull. Usually I would just pull from the time of your mail, but it looks like some important changes have gone in since.
Regards, Cory On Wed, Oct 19, 2011 at 1:27 AM, trizinn <[email protected]> wrote: > Thanks Cory, I've made the necessary changes. > > On Mon, Oct 17, 2011 at 2:30 PM, Cory Fields <[email protected]> wrote: >> >> On Sun, Oct 16, 2011 at 6:31 PM, trizinn <[email protected]> wrote: >> > Please disregard the revision number I gave and pull the latest off the >> > dharma branch. I fixed a few things. >> > >> > On Sat, Oct 15, 2011 at 7:44 PM, trizinn <[email protected]> wrote: >> >> >> >> Yes, eden-pre will be the master branch going forward. Although I am >> >> not >> >> ready for a pull at the moment. Wanting to get Dharma out first. Just >> >> let me >> >> know what needs to be changed. >> >> >> >> On Sat, Oct 15, 2011 at 7:35 PM, Cory Fields <[email protected]> wrote: >> >>> >> >>> On Sat, Oct 15, 2011 at 8:24 PM, trizinn <[email protected]> wrote: >> >>> > addon - skin.rapier >> >>> > version - 4.00 >> >>> > url - git://github.com/scarfa/skin.rapier.git >> >>> > revision - ec35ab8dd0 >> >>> > branch - dharma >> >>> > xbmc version - dharma >> >>> > >> >>> > -- >> >>> > - Tran >> >>> > >> >>> > >> >>> > >> >>> > ------------------------------------------------------------------------------ >> >>> > All the data continuously generated in your IT infrastructure >> >>> > contains >> >>> > a >> >>> > definitive record of customers, application performance, security >> >>> > threats, fraudulent activity and more. Splunk takes this data and >> >>> > makes >> >>> > sense of it. Business sense. IT sense. Common sense. >> >>> > http://p.sf.net/sfu/splunk-d2d-oct >> >>> > _______________________________________________ >> >>> > Xbmc-addons mailing list >> >>> > [email protected] >> >>> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> >>> > >> >>> > >> >>> >> >>> Nice, will get to this asap. >> >>> >> >>> I'm not sure if you follow the list.. it usually takes a few rounds of >> >>> back and forth to get things ready for the first push to the repo, but >> >>> smooth sailing after that. >> >>> >> >>> Is there one coming for eden-pre soon as well? >> >>> >> >>> Regards, >> >>> Cory >> >> >> >> >> >> >> >> -- >> >> - Tran >> > >> > >> > >> > -- >> > - Tran >> > >> >> Ok, let's get this going. As I said, almost all skins have these >> issues for first push to the repo, so they're no big deal as long as >> we can get them cleaned up. >> >> 1. license.txt -> LICENSE.txt >> 2. please add a changelog. It's ok if it just says "initial release" >> for now, but we require it for future bumps so that users can see >> (from xbmc) what's changed. >> 3. Please add a folder called "_screenshots" with 5-10 reasonably >> sized jpegs inside. While not mandatory for dharma, I am encouraging >> this as they will be required for eden. >> 4. We require 100% validated xml files, that way it's much easier to >> spot malformed files for future updates. Please use a validation tool >> to test/fix. Mine shows the following files as invalid (it seems most >> are silly nits about encoding specification or out-of-spec comments): >> ./720p/custom_About.xml - invalid >> ./720p/includes_InfoPane.xml - invalid >> ./720p/ViewsCommon.xml - invalid >> ./720p/includes_Animations.xml - invalid >> ./720p/ViewsMovies.xml - invalid >> ./720p/ViewsAddons.xml - invalid >> ./720p/ViewsTVShows.xml - invalid >> ./720p/includes_MediaFlags.xml - invalid >> ./720p/ViewsMusic.xml - invalid >> ./720p/ViewsEpisodes.xml - invalid >> >> 5. Please update the readme to reflect that users should install from >> the official repo, otherwise anyone who comes across would be >> confused. >> >> Great job! Rapier has always been one of my personal favorites ;) >> >> Regards, >> Cory > > > > -- > - Tran > ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
