Updated.
I saw that you put back all the languages.
If they are so outdated that completely out of sync, then it might be
better to remove them for the next pull request (not urgent).
Cheers,
Bence
On Thu, Nov 17, 2011 at 3:27 PM, MaDDoGo <[email protected]> wrote:
> Hi,
>
> I've done all things you tell me so I hope you can clone it perfect now.
>
> Cheers!
>
>
> 2011/11/17 Olympia <[email protected]>
>
>> ...and one more, sorry, we also don't need the .gitignore file in the
>> repo root.
>>
>> Thanks,
>> Bence
>>
>>
>> On Thu, Nov 17, 2011 at 10:24 AM, Olympia <[email protected]> wrote:
>>
>>> Hi,
>>>
>>> OK, looks good, thanks!
>>> Now the last important bit which I forgot to mention in my previous mail
>>> would be to remove the metadata.filmaffinity.com folder from the repo.
>>> Just simply dump the scraper files into the repo without the folder. Now I
>>> cannot clone it properly.
>>>
>>> Thanks,
>>> Bence
>>>
>>>
>>> On Thu, Nov 17, 2011 at 9:22 AM, MaDDoGo <[email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> I look into the issues you tell me. About the first one, the scraper is
>>>> done in spanish and translated to English (now is perfect) and other
>>>> translations are out-to-date. Readme is out, it was there because of github
>>>> recommended to do that.
>>>>
>>>> I've commited changes and this are the URL with the commit.
>>>>
>>>>
>>>> https://github.com/MaDDoGo/metadata.filmaffinity.com/commit/3ff36d19c802cb9c33113d21e921027a456e285c
>>>>
>>>> Cheers!
>>>>
>>>>
>>>> 2011/11/17 Olympia <[email protected]>
>>>>
>>>>> Hi,
>>>>>
>>>>> I have a few comments:
>>>>> - did you deleted all the translations on purpose? English must be
>>>>> there as a minimum.
>>>>> - there is an empty readme file in resources folder - please remove
>>>>> this one
>>>>> - in changelog.txt the version number is wrong
>>>>>
>>>>> could you please have a look at these?
>>>>>
>>>>> Thanks,
>>>>> Bence
>>>>>
>>>>>
>>>>> On Wed, Nov 16, 2011 at 9:11 PM, MaDDoGo <[email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> this is my first git update so I hope I am doing it right.
>>>>>>
>>>>>> Cheers
>>>>>>
>>>>>> PS: Updated to version 1.4 to solve some web problems.
>>>>>>
>>>>>> *addon - metadata.filmaffinity.com
>>>>>> *version - 1.4
>>>>>> *url - git://github.com/MaDDoGo/metadata.filmaffinity.com.git
>>>>>> *revision - ecdf473df665a367fcfe45827a8c5c37f79326d5
>>>>>> *branch - master
>>>>>> *xbmc version - dharma, eden-pre
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> All the data continuously generated in your IT infrastructure
>>>>>> contains a definitive record of customers, application performance,
>>>>>> security threats, fraudulent activity, and more. Splunk takes this
>>>>>> data and makes sense of it. IT sense. And common sense.
>>>>>> http://p.sf.net/sfu/splunk-novd2d
>>>>>> _______________________________________________
>>>>>> Xbmc-addons mailing list
>>>>>> [email protected]
>>>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
