Ok, here we go. It's normal to have a bunch of issues to resolve when
a skin is first submitted, so don't be alarmed by the list below. I'm
certainly not.
- revision aabb120 does not exist. So I'm reviewing current master (0edb3d)
- please rename to skin.xperience-more or skin.xperience_more. The .
and caps could cause us grief in the future.
- version needs major.minor.revision. 1.2.0 would be fine.
- please fix the xml's that don't validate. Most are just due to
missing encoding indicators:
$ find -name "*.xml" -exec xmlstarlet val "{}" \; | grep -i invalid
./Viewtype_Music.xml - invalid
./Viewtype_Posters music.xml - invalid
./script-globalsearch-main.xml - invalid
./PlayerControls.xml - invalid
./Includes_Animations.xml - invalid
./Viewtype_Posters_Big.xml - invalid
./Viewtype_Home_Panels.xml - invalid
./Font.xml - invalid
./Includes_Window-Contents.xml - invalid
./Includes_Home.xml - invalid
./Viewtype_Posters_Programs.xml - invalid
./script-XBMC-Subtitles-main.xml - invalid
./Viewtype_TV Show Banners.xml - invalid
./Viewtype_File Panel.xml - invalid
./DialogSelect.xml - invalid
./Viewtype_Walls_Full_Programs.xml - invalid
./Viewtype_Fanart_Tri_Panel.xml - invalid
./Viewtype_Slide.xml - invalid
./Viewtype_Slide_Programs.xml - invalid
./Custom_Settings.xml - invalid
./Viewtype_Walls_Full.xml - invalid
- please no spaces in XML names. There are already a few cases of
this, but it proves to be a headache during packaging and I'd rather
not continue the trend.
- missing screenshots. Please add a folder at the skin's root dir
called "_screenshots" (with the underscore) and include around 10
jpegs.
- script.watchlist: If you're going to use it, you need to depend on it
- Includes.xml -> includes.xml. This really makes me worry about other
case-sensitive issues, the skin is entirely black in Linux due to the
missing includes.
- various issues during use, some of these may be resolved by making
the xml's validate:
00:14:24 T:140536173619136 INFO: Loading skin file: MyVideoNav.xml
00:14:24 T:140536173619136 WARNING: Trying to add unsupported control type 3
00:14:24 T:140536173619136 WARNING: Previous line repeats 2 times.
00:14:24 T:140536173619136 ERROR: unmatched parentheses in
SubString(ListItem.videoresolution,480
00:14:24 T:140536173619136 ERROR: unmatched parentheses in
substring(listitem.VideoResolution,1080
00:14:24 T:140536173619136 ERROR: unmatched parentheses in
substring(ListItem.filename,540p
00:14:24 T:140536173619136 WARNING: Trying to add unsupported control type 3
00:14:24 T:140536173619136 ERROR: Control has invalid animation type
(no condition or no type)
00:14:24 T:140536173619136 ERROR: Previous line repeats 8 times.
00:14:24 T:140536173619136 WARNING: Trying to add unsupported control type 3
00:14:24 T:140536173619136 WARNING: Previous line repeats 3 times.
Please let me know when those are worked out and I'll beat you up some more ;)
Nice job on the skin, keep up the good work!
Regards,
Cory
On Tue, Apr 17, 2012 at 2:43 AM, Cory Fields <[email protected]> wrote:
> Ok, That's good enough for me. I'll give it an initial review.
>
> Regards,
> Cory
>
> On Sun, Apr 15, 2012 at 2:34 PM, Jezz_X <[email protected]> wrote:
>> Yeah I was also under the impression that team blackbolt were not
>> working on this anymore or anything really
>>
>> On Sun, Apr 15, 2012 at 10:35 PM, Nessus <[email protected]> wrote:
>>> Original Xperience was abandoned more than a year now. Many times I try to
>>> contact the project leader (XBMCG33K) but I didn’t get any answer. If you
>>> manage to contact with him ask him if is ok otherwise no problem.
>>>
>>> Since is my favorite skin in the beginning i was trying to make the skin
>>> compatible with newer versions of XBMC but now I've rewrite the code and
>>> create the graphics for more than the 70% of the skin.
>>>
>>> Xperience More v1.2
>>> http://forum.xbmc.org/showthread.php?tid=103818
>>>
>>> Cheers
>>> Nessus
>>>
>>>
>>> --------------------------------------------------
>>> From: "Cory Fields" <[email protected]>
>>> Sent: Saturday, April 14, 2012 10:21 AM
>>> To: "Nessus" <[email protected]>
>>> Cc: <[email protected]>; "Team Blackbolt"
>>> <[email protected]>; <[email protected]>
>>> Subject: Re: [Xbmc-addons] [Git Pull] Skin Xperience More
>>>
>>>> On Fri, Apr 13, 2012 at 4:09 PM, Nessus <[email protected]> wrote:
>>>>> *addon - skin.xperience.more
>>>>> *version - 1.2
>>>>> *url - git://github.com/Nessus85100/Xperience.More.git
>>>>> *revision – aabb120
>>>>> *branch - master
>>>>> *xbmc version – eden
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> For Developers, A Lot Can Happen In A Second.
>>>>> Boundary is the first to Know...and Tell You.
>>>>> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
>>>>> http://p.sf.net/sfu/Boundary-d2dvs2
>>>>> _______________________________________________
>>>>> Xbmc-addons mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>>
>>>>
>>>> Hmm, I'm a bit uncomfortable with this seeing as there's not one from
>>>> the Blackbolt guys in yet.
>>>>
>>>> CCing for their opinion.
>>>>
>>>> Regards,
>>>> Cory
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> For Developers, A Lot Can Happen In A Second.
>>> Boundary is the first to Know...and Tell You.
>>> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
>>> http://p.sf.net/sfu/Boundary-d2dvs2
>>> _______________________________________________
>>> Xbmc-addons mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>> ------------------------------------------------------------------------------
>> For Developers, A Lot Can Happen In A Second.
>> Boundary is the first to Know...and Tell You.
>> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
>> http://p.sf.net/sfu/Boundary-d2dvs2
>> _______________________________________________
>> Xbmc-addons mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
