A few comments.
- Please don't request an update every day (or even multiple a day) -
please test your code before requesting an update.
- Still untranslated ones... Looks like you reverted the translation on
these with your last commits...
'My Recordings' (L98)
'Favourites' (L100)
- Your icon has transparency which (like wiki said) is not wanted.
- You should not call direct the Player, use setResolvedUrl() instead. At
the moment you are providing an item-list AND calling the player which is
(at least) very irregular
- Thread spawning.... Your code opens a timed thread which opens another
timed thread and so on. Even when playback is stopped it continues. Even
when xbmc wants to exit the threads stay open (and they sum on) - they need
to be killed the hard way - which delays XBMC exit.
- At least your german translation is crap:
<string id="30016">Jedes Ding ELSE</string>">
<string id="30029">Anmeldung fehlgeschlagen EXIT Filmon UND TRY AGAIN</string>">
- Your italian, spanish, german translations are no valid xml:
<string id="30290">Gran Bretaña</string>">
Regards,
sphere
2012/11/14 Mike Simmonds <[email protected]>
> Final Pull Request Stable
>
> Added All Supporting Languages
> French,German,Russian,Italian And Spanish
>
> Added Better Description in addon.xml for users
> Added If channel is Subscribed to High Stream Will Automatically Play
>
> *addon – plugin.video.filmon
> *version – 3.1.8
> *url - git://github.com/XBMCFILMON/plugin.video.filmon.git
> *revision – d6f05a7e82702a7f93e11b817515450e4ae38648
> *branch – master
> *xbmc version – eden
>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
