Hi, uh oh,

this happende cause team xbmc decided to mess with the query string used to
launch plugins in frodo, of course i forgot that some plugins store percent
encoded strings in the url.

I'll look into a bug fix asap.

Regards HenrikDK

On Fri, Nov 23, 2012 at 11:32 PM, Johan Wieslander <
[email protected]> wrote:

> Hi,
>
> Do you know your latest commit for commonFunctions breaks quite many
> addons :D
>
>
> http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py
>
>     1.13 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.13>
>   def getParameters(parameterString):    1.14 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.14>
>       log("", 5)    1.15 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.15>
>       commands = {}    1.16 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.16>
>  +    parameterString = urllib.unquote_plus(parameterString)    1.17 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.17>
>       splitCommands = parameterString[parameterString.find('?') + 
> 1:].split('&')    1.18 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.18>
>       1.19 
> <http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/diff/9f87620e97e0/lib/CommonFunctions.py#l1.19>
>       for command in splitCommands:
>
>
> Example
>
> When this is getting called: 
> "plugin://plugin.video.svtplay/?url=%2Fvideo%2F585441%2F18-11-08-25%253Ftype%253Dembed&mode=video"
>
>
> The addon runs this:
>
> params = common.getParameters(sys.argv[2])
>
>
> url = params.get("url", "")
>
>
> Since you added unquote_plus the result is that %253F gets converted to & and 
> the whole parameter splitting getting wrong...
>
>
>
> On Wed, Nov 21, 2012 at 10:46 PM, Benjamin BERTRAND <
> [email protected]> wrote:
>
>> http://wiki.xbmc.org/index.php?title=Official_Add-on_Repository
>> See 4.2:
>> Body:
>>
>>  *addon -   my.cool.plugin
>>  *version - 1.1.0
>>  *url - git://some.where.git
>>  *revision - a241345a
>>  *branch - master
>>  *xbmc version - dharma
>>
>> /beenje
>>
>>
>> Le 21 nov. 2012 à 22:38, Henrik Jensen <[email protected]>
>> a écrit :
>>
>> Hi Attila, saw your message, sorry i didnt respond, well see if we cant
>> integrate it in the next release..
>>
>> Regarding the format, can anyone point me in the right direction of the
>> wiki article that describes the format.
>>
>> Regards HenrikDK
>>
>> On Wed, Nov 21, 2012 at 8:24 AM, Attila Jakosa <[email protected]> wrote:
>>
>>> Hi HenrikDK !
>>>
>>> I tried to reach you on the forums, but no luck yet.
>>>
>>> Just wanted to notice that I added this plugin to the XBMC Transifex
>>> translation project:
>>>
>>> https://www.transifex.com/projects/p/XBMC-Main-Frodo/resource/plugin-video-youtube/
>>>
>>> And already a lot of languages has 100% completion.
>>>
>>> All fresh language files are always kept in sync with your upstream repo
>>> here:
>>>
>>> https://github.com/xbmc/translations/tree/master/translations/xbmc-main-frodo/merged-langfiles/addons_ext_plugins/plugin.video.youtube
>>>
>>> I've created strings.xml files to keep compatibility with Eden.
>>> Could you please pull in these translations from time to time ?
>>> Thanks!
>>>
>>> Cheers,
>>> Attila
>>>
>>> 2012/11/20 Benjamin Bertrand <[email protected]>
>>>
>>>> All updated for eden and frodo.
>>>> Please try to use the body format described in the wiki (with the
>>>> keywords: *addon,  *version, *url...) next time so it can be parsed
>>>> automatically.
>>>>
>>>> Cheers,
>>>>
>>>> /beenje
>>>>
>>>> On Tue, Nov 20, 2012 at 12:06 AM, Henrik Jensen <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Waay to much time passed between the last update and this. As a result
>>>>> a lot of plugins broke in the meantime, we're still prepping for frodo, 
>>>>> but
>>>>> all of the plugins in this release should work on both eden and frodo, but
>>>>> we're still working on a fix for the downloader, the existing downloader
>>>>> will work in frodo but no UI will be shown until the file is downloaded.
>>>>>
>>>>> plugin.video.youtube
>>>>> Version 3.3.0
>>>>> hg clone http://hg.tobiasussing.dk/hgweb.cgi/youtubexbmc/ plugin.video
>>>>> .youtube -b release -r 37f6961bc493
>>>>>
>>>>> plugin.video.vimeo
>>>>> Version 2.4.0
>>>>> hg clone http://hg.tobiasussing.dk/hgweb.cgi/vimeoxbmc/ plugin.video.vimeo
>>>>> -b release -r 97d7a50da8dc
>>>>>
>>>>> plugin.video.bliptv
>>>>> Version 0.7.0
>>>>> hg clone http://hg.tobiasussing.dk/hgweb.cgi/bliptvxbmc/
>>>>> plugin.video.bliptv -b release -r 26870496757c
>>>>>
>>>>> script.module.parsedom
>>>>> Version 1.3.0
>>>>> hg clone 
>>>>> http://hg.tobiasussing.dk/hgweb.cgi/commonxbmc/script.module.parsedom -b 
>>>>> release -r 9f87620e97e0
>>>>>
>>>>> Regards HenrikDK
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>>> web console. Get in-depth insight into apps, servers, databases,
>>>>> vmware,
>>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>>> Pricing starts from $795 for 25 servers or applications!
>>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>>> _______________________________________________
>>>>> Xbmc-addons mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>>
>>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>> Pricing starts from $795 for 25 servers or applications!
>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>> _______________________________________________
>>>> Xbmc-addons mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>
>>>>
>>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Monitor your physical, virtual and cloud infrastructure from a single
>> web console. Get in-depth insight into apps, servers, databases, vmware,
>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> Pricing starts from $795 for 25 servers or applications!
>> http://p.sf.net/sfu/zoho_dev2dev_nov
>> _______________________________________________
>> Xbmc-addons mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>>
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to