Updated both for eden and frodo.

Cheers

beenje

On Wed, Nov 28, 2012 at 3:40 AM, Ryan Kraus <[email protected]> wrote:
> *addon - service.script.isyevents*version - 0.1.0
> *url -
> https://isy-events.googlecode.com/svn/tags/v0.1.0/service.script.isyevents
> *revision - 17
> *branch - eden frodo
> *xbmc version - eden frodo
>
> Here you are.
>
> Forgot to reply to the list last time.
>
>
> Ryan Kraus
>
>
> On Tue, Nov 27, 2012 at 5:02 PM, Benjamin Bertrand
> <[email protected]> wrote:
>>
>> plugin.program.isybrowse updated both for eden and frodo.
>> But the 2nd url doesn't exist. Looks like you forgot to change the
>> name to service.script.isyevents in your pull request.
>> Could you send a new one to be sure?
>>
>> /beenje
>>
>> On Tue, Nov 27, 2012 at 3:33 AM, Ryan Kraus <[email protected]> wrote:
>> > *addon - plugin.program.isybrowse
>> > *version - 0.1.0
>> > *url -
>> >
>> > https://isy-events.googlecode.com/svn/tags/v0.1.0/plugin.program.isybrowse
>> > *revision - 17
>> > *branch - eden frodo
>> > *xbmc version - eden frodo
>> >
>> > *addon - script.service.isyevents
>> > *version - 0.1.0
>> > *url -
>> >
>> > https://isy-events.googlecode.com/svn/tags/v0.1.0/script.service.isyevents
>> > *revision - 17
>> > *branch - eden frodo
>> > *xbmc version - eden frodo
>> >
>> > These issues have all been addressed.  Thanks for your patience on this
>> > one.
>> >
>> >
>> > Ryan Kraus
>> >
>> >
>> > On Mon, Nov 26, 2012 at 5:30 PM, Benjamin Bertrand
>> > <[email protected]> wrote:
>> >>
>> >> 1. The minimum version for plugin.program.isybrowse is set to 0.0.1 in
>> >> script.service.isyevents addon.xml
>> >> It should be 0.1.0 (the first version you provided).
>> >>
>> >> 2. Language tag(s). These are the language(s) of the *content*
>> >> provided by your add-on.
>> >> You set it to "en", but it should rather be empty as there isn't
>> >> really a language associated to the *content*.
>> >> See http://wiki.xbmc.org/index.php?title=Add-on_development
>> >>
>> >> 3. If possible, could you rename your script
>> >> "service.script.isyevents" (instead of script.service.isyevents) to be
>> >> more consistent with existing services.
>> >> But that's not mandatory.
>> >>
>> >> After that it should be ok.
>> >>
>> >> /beenje
>> >>
>> >>
>> >> On Sun, Nov 25, 2012 at 5:47 AM, Ryan Kraus <[email protected]> wrote:
>> >> > *addon - plugin.program.isybrowse
>> >> > *version - 0.1.0
>> >> > *url -
>> >> >
>> >> >
>> >> > https://isy-events.googlecode.com/svn/tags/v0.1.0/plugin.program.isybrowse
>> >> > *revision - 16
>> >> > *branch - eden frodo
>> >> > *xbmc version - eden frodo
>> >> >
>> >> > *addon - script.service.isyevents
>> >> > *version - 0.1.0
>> >> > *url -
>> >> >
>> >> >
>> >> > https://isy-events.googlecode.com/svn/tags/v0.1.0/script.service.isyevents
>> >> > *revision - 16
>> >> > *branch - eden frodo
>> >> > *xbmc version - eden frodo
>> >> >
>> >> > 1) That was a typo on my part. My bad. ISY Events is a script, not a
>> >> > plugin.
>> >> > 2) I changed the names to plugin.program.isybrowse and
>> >> > script.service.isyevents.
>> >> > 3-4) I removed the LICENSE.docx and Thumbs.db files.  My bad (again),
>> >> > I
>> >> > thought I had Tortoise set to ignore the Thumbs files.
>> >> >
>> >> > Thanks,
>> >> >
>> >> > Ryan Kraus
>> >> >
>> >> >
>> >> > On Sat, Nov 24, 2012 at 5:31 PM, Benjamin Bertrand
>> >> > <[email protected]> wrote:
>> >> >>
>> >> >> Yes, it's ok to do two at once.
>> >> >> Just a few comments after a quick look:
>> >> >>
>> >> >> 1. svn: URL
>> >> >> 'https://isy-events.googlecode.com/svn/tags/v0.1.0/plugin.isyevents'
>> >> >> doesn't exist
>> >> >>
>> >> >> 2. If those are programs, you should rename them
>> >> >> "plugin.program.xxxxxxx"
>> >> >>
>> >> >> 3. There should be no LICENSE.docx (LICENSE.txt only).
>> >> >>
>> >> >> 4. Please remove the Thumbs.db
>> >> >>
>> >> >> /beenje
>> >> >>
>> >> >> On Sat, Nov 24, 2012 at 7:05 AM, Ryan Kraus <[email protected]>
>> >> >> wrote:
>> >> >> > *addon - plugin.isybrowse
>> >> >> > *version - 0.1.0
>> >> >> > *url -
>> >> >> > https://isy-events.googlecode.com/svn/tags/v0.1.0/plugin.isybrowse
>> >> >> > *revision - 15
>> >> >> > *branch - eden frodo
>> >> >> > *xbmc version - eden frodo
>> >> >> >
>> >> >> > *addon - plugin.isyevents
>> >> >> > *version - 0.1.0
>> >> >> > *url -
>> >> >> > https://isy-events.googlecode.com/svn/tags/v0.1.0/plugin.isyevents
>> >> >> > *revision - 15
>> >> >> > *branch - eden frodo
>> >> >> > *xbmc version - eden frodo
>> >> >> >
>> >> >> > My first submissions so I hope doing two at once is OK. isyevents
>> >> >> > requires
>> >> >> > isybrowse. The XML file for isyevents reflects this. These addons
>> >> >> > bring
>> >> >> > home
>> >> >> > automation control into XBMC.
>> >> >> >
>> >> >> > Ryan Kraus
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > ------------------------------------------------------------------------------
>> >> >> > Monitor your physical, virtual and cloud infrastructure from a
>> >> >> > single
>> >> >> > web console. Get in-depth insight into apps, servers, databases,
>> >> >> > vmware,
>> >> >> > SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> >> >> > Pricing starts from $795 for 25 servers or applications!
>> >> >> > http://p.sf.net/sfu/zoho_dev2dev_nov
>> >> >> > _______________________________________________
>> >> >> > Xbmc-addons mailing list
>> >> >> > [email protected]
>> >> >> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>> >> >> >
>> >> >
>> >> >
>> >
>> >
>
>

------------------------------------------------------------------------------
Keep yourself connected to Go Parallel: 
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve.
http://goparallel.sourceforge.net
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to