Just a few more comments:
- Please add a "langage" tag in your addon.xml (see
http://wiki.xbmc.org/index.php?title=Add-on_development)
- Line 59 in resources/lib/qobuz/registry.py, I think you have a wrong key.
It should be ka['username'], not ka['user]
- the file description.xml is not used (only addon.xml is). You can remove
it.
- add a version number for the script.module.requests (especially if it's
not compatible with 0.13.2). Set it to 1.0.4.
- and last, could you please convert all your files to unix eol's?
After, it should be ok :-)
IIUC, the plugin is not compatible with requests 0.13.2. So I'll have to
wait for other devs updates to push requests 1.0.4 and your plugin at the
same time.
On Sat, Dec 29, 2012 at 12:39 AM, Cyril Leclerc <[email protected]>wrote:
> Thanks !
> i've updated following your comments (and updated python xbmc version
> requirements to 2.1.0)
>
> *addon - plugin.audio.qobuz
>
> *version - 0.10.1
>
> *url - [email protected]:tidalf/plugin.audio.qobuz.git
>
> *revision - 34eb8cbf4a
>
> *branch - master
> *xbmc version - frodo
>
> Cheers,
> --
> Cyril
>
> Le 28 déc. 2012 à 23:50, Benjamin Bertrand <[email protected]> a
> écrit :
>
> I will send an announcement about the new requests module and let a
> few days to the devs to react.
>
> A few first comments about your pr:
> Please remove default.tbn.
> Rename gpl.txt to LICENSE.txt.
> icon should be 256x256
>
>
> On Fri, Dec 28, 2012 at 12:27 PM, Cyril Leclerc <[email protected]>
> wrote:
>
> *addon - plugin.audio.qobuz
> *version - 0.10.1
> *url - [email protected]:tidalf/plugin.audio.qobuz.git
> *revision - 1dd66315b0
> *branch - master
> *xbmc version - frodo
>
> Bug fix update (tested with request 1.0.4)
>
>
>
> On Wed, Dec 26, 2012 at 7:44 PM, Cyril Leclerc <[email protected]>
> wrote:
>
>
> *addon - plugin.audio.qobuz
> *version - 0.10.0
> *url - [email protected]:tidalf/plugin.audio.qobuz.git
> *revision - 7c90a76958
> *branch - master
> *xbmc version - frodo
>
> This is a addon to use the Qobuz music stream service, there is a thread
> in the forum here :
> http://forum.xbmc.org/showthread.php?tid=146568
>
>
>
> Thanks !
>
>
>
>
> ------------------------------------------------------------------------------
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
>
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
