Hey guys,
don't get me wrong but what's going on with this new requirements for skins?
- Remove BOM: it did not matter all the time but suddenly Frodo got picky?
- <onclick>-</onclick> : was used for years in Confluence and all of the
sudden we should change to <onclick>poop</onclick> ?
Thanks
On Sat, Jan 26, 2013 at 4:57 PM,
<[email protected]>wrote:
>
> ---------- Forwarded message ----------
> From: ronie <[email protected]>
> To: jingai <[email protected]>, xbmc-addons <
> [email protected]>
> Cc:
> Date: Fri, 25 Jan 2013 23:29:03 +0100
> Subject: Re: [Xbmc-addons] [git pull] Metropolis 2.6.2
> On 25/01/13 04:50, jingai wrote:
>
>> * addon - skin.metropolis
>> * version - 2.6.2
>> * url -
>> git://github.com/stoli/**Metropolis.git<http://github.com/stoli/Metropolis.git>
>> * branch - master
>> * revision - 367ecac25d16b065ffa56f2cfad138**d86d762473
>> * xbmc version - frodo
>>
>>
> hey jingai,
>
> thx for submitting the pull request!
> would be pretty cool to get Metroplis into the frodo repo :)
>
> as always, the first pull is the toughest and takes a bit of work to get
> things in shape.
> subsequent submissions should go easy as a breeze though.
>
>
> i did a checkup on the skin and came up with this list of needed changes:
>
> - Please fix (or remove) these filenames:
> extras\recordlabels\Rosenst�**rm.png (invalid encoding)
> extras\recordlabels\Rosenst�**rm.png (invalid encoding)
> extras\studios\ 42 files in this folder have invalid encoding
> media\flags\RecordLabels\**Rosenst�rm.png (invalid encoding)
> media\flags\RecordLabels\Var�**se Sarabande.png (invalid encoding)
>
>
> - Remove this file:
> media\flags\Stars\Banner 10 star code.txt
>
>
> - Remove these folders + contents:
> media\moviegenres\Docs
> media\musicgenres\Docs
>
>
> - Reduce the number of files in the _screenshots folder (max 10
> screenshots)
>
>
> - Remove the BOM at the start of every .xml file in 720p
> see:
> http://www.bryntyounce.com/**filebomdetector.htm<http://www.bryntyounce.com/filebomdetector.htm>
>
>
> - Please localize these hardcoded strings
> Includes_Home1.xml: <label>Browser</label>
> Includes.xml: <label>[B]AM[/B]</label>
> Includes.xml: <label>[B]PM[/B]</label>
> Includes.xml: <label>$INFO[ListItem.**PictureExpTime] @ ISO
> $INFO[ListItem.PictureISO]</**label>
> MyWeather.xml: <label>N/A</label> (8x)
>
>
> - Undefined Includes:
> MusicVisualisation.xml: <include>VisibleFadeEffect</**include>
> script-NextAired-TVGuide.xml: <include>VisibleFadeEffect</**include>
> SettingsScreenCalibration.xml: <include>DialogID</include>
>
>
> - Unmatched parenthesis
> DialogVideoInfo.xml: <visible>Container.Content(**MusicVideos)]</visible>
> DialogSeekBar.xml: <visible>Window.IsActive(**fullscreenvideo) |
> Window.IsActive(Visualisation)**]</visible>
> Includes.xml: <visible>[Window.IsActive(**musiclibrary) |
> Window.IsActive(musicfiles)] + !SubString(Container.**FolderPath,addons)
> + !SubString(Container.**FolderPath,plugin)]</visible>
>
>
> - It's not possible to focus image controls
> Pointer.xml: ERROR: Control 1 in window 10099 has been asked to focus, but
> it can't
>
>
> - Undefined window (extprogress), should be 'extendedprogressdialog' i
> guess
> DialogProgress.xml: <animation effect="slide" end="0,-300" time="300"
> reversible="false" condition="Window.IsActive(**
> extprogress)">Conditional</**animation>
> DialogVideoInfo.xml: <visible>!Container.Content(**episodes) +
> !Window.IsActive(extprogress)<**/visible>
> DialogVideoInfo.xml: <visible>Container.Content(**episodes) +
> !Window.IsActive(extprogress)<**/visible>
>
>
> - Undefined action '-', use 'noop' instead: <onclick>noop</onclick>
> SkinSettings.xml: <onclick>-</onclick>
> SmartPlayListEditor.xml: <onleft>-</onleft>
> SmartPlayListEditor.xml: <onright>-</onright>
> script-globalsearch-**infodialog.xml:<onclick>-</**onclick>
> ProfileSettings.xml: <onright>-</onright>
> ProfileSettings.xml: <onleft>-</onleft>
> MyMusicPlaylistEditor.xml: <onleft>-</onleft>
> MyMusicPlaylistEditor.xml: <onright>-</onright>
> Includes.xml: <ondown>-</ondown>
> Includes.xml: <onright>-</onright>
> FileBrowser.xml: <onright>-</onright>
> FileBrowser.xml: <onleft>-</onleft>
> DialogSelect.xml: <onright>-</onright>
> DialogSelect.xml: <onright>-</onright>
> DialogSlider.xml: <onup>-</onup>
> DialogSlider.xml: <ondown>-</ondown>
> DialogPeripheralManager.xml: <onright>-</onright>
> DialogPeripheralSettings.xml: <onright>-</onright>
> DialogMediaSource.xml: <onright>-</onright>
> DialogMediaSource.xml: <onleft>-</onleft>
> DialogNetworkSetup.xml: <onleft>-</onleft>
> 21:59:23 T:139844913952640 DEBUG: ExecuteXBMCAction : Translating -
> 21:59:23 T:139844913952640 DEBUG: ExecuteXBMCAction : To -
> 21:59:23 T:139844913952640 ERROR: Keymapping error: no such action '-'
> defined
>
> there's quite a few of those throughout the skin, so the listing above
> might be incomplete.
>
>
> - Case sensitive issue, rename Defaults.xml to defaults.xml
> WARNING: CreateFile, successfuly opened </home/ronie/.xbmc/addons/**
> skin.metropolis/720p/Defaults.**xml> instead of </home/ronie/.xbmc/addons/
> **skin.metropolis/720p/defaults.**xml>
>
>
> - Unused textures ?
> extras\logos\
> extras\recordlabels\
> media\..\backup ?
> not a real showstopper but i have the feeling there's quite a few unused
> textures in the media folder and subfolders.
> if possible, please check and remove whatever you don't need, so we can
> keep skin sizes sane.
>
>
> should you have any questions or need help with any of the above, don't
> hesitate to ask :-)
>
>
> cheers,
> ronie
>
>
>
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
