On Jan 25, 2013, at 5:29 PM, ronie <[email protected]> wrote: > i did a checkup on the skin and came up with this list of needed changes: > > - Please fix (or remove) these filenames: > extras\recordlabels\Rosenst�rm.png (invalid encoding) > extras\recordlabels\Rosenst�rm.png (invalid encoding) > extras\studios\ 42 files in this folder have invalid encoding > media\flags\RecordLabels\Rosenst�rm.png (invalid encoding) > media\flags\RecordLabels\Var�se Sarabande.png (invalid encoding)
I presume these match what is returned by scrapers. If we can't have filenames with foreign encodings, how do you match these? > - Remove this file: > media\flags\Stars\Banner 10 star code.txt > > - Remove these folders + contents: > media\moviegenres\Docs > media\musicgenres\Docs These are just docs for developers. Because they're not actually referenced in the skin, I figured they'd be harmless. I find it useful to have them in-tree where they'd be immediately visible. But, I'll remove them if it's really an issue.. > - Please localize these hardcoded strings > Includes.xml: <label>[B]AM[/B]</label> > Includes.xml: <label>[B]PM[/B]</label> I've done this, but FYI, it will break the layout if it's anything other than AM and PM. I believe that's was why it was hard-coded. > - It's not possible to focus image controls > Pointer.xml: ERROR: Control 1 in window 10099 has been asked to focus, but it > can't Looking into what's causing this.. > - Unused textures ? > extras\logos\ > extras\recordlabels\ > media\..\backup ? > not a real showstopper but i have the feeling there's quite a few unused > textures in the media folder and subfolders. > if possible, please check and remove whatever you don't need, so we can keep > skin sizes sane. There are, I'm sure, some unused textures. Mostly they're alternate choices. Others are used for media flags and the like (that is, they match something returned from a scraper, not something in the skin). Still others are for button/frame/etc styles that could be in the skin but are currently not utilized. I don't really have the time to go through all these right now.. but I can make an Issue on our github. Is that OK for now? The rest of the issues you noticed have been addressed. Would you mind running your checker again against 3651ddabd354fdca7c804af1abfb8392b57f4e56 ? -jingai ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
