I have some concerns about the code
https://github.com/robweber/xbmclibraryautoupdate/blob/master/service.py#L54
sleep of 10 seconds is way to long.
Make it something like this http://pastebin.com/5QQGH7cj
Other possibility is (suggestion):
AlarmClock(name,command,time[,silent,loop])
http://wiki.xbmc.org/index.php?title=List_of_built-in_functions
use xbmc.monitor to check for addon setting changes and cancel and restart
alarmclock when needed.
http://wiki.xbmc.org/index.php?title=List_of_built-in_functions
never do a while without xbmc.abortrequest
Better check the condition before even entering the def "evalSchedules(self)
"
https://github.com/robweber/xbmclibraryautoupdate/blob/master/service.py#L65
These are just some points I found.
Using the right stuff you can reduce a lot of code
Martijn
On Mon, Jan 28, 2013 at 7:57 PM, Rob Weber <[email protected]> wrote:
> *addon - service.libraryautoupdate
> *version - 0.7.7
> *url - git://github.com/robweber/xbmclibraryautoupdate.git
> *revision - cd52d973ef4a8293e63825ee46eaed912606fe66
> *branch - master
> *xbmc version - frodo
>
> lots of updates this time. big ticket things include removing common
> plugin cache dependency and storing things using the xbmcaddon.setSetting()
> method instead. Also rewrote some of the service code to use the
> xbmc.Monitor python class instead of having wait blocks in the code. Other
> minor logic enhancements.
>
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnnow-d2d
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
