On 08/02/13 05:00, stephen paul wrote:


* addon - skin.carmichael
* version - 2.1.3

* url - [email protected]:mcborzu/carmichael.git
* branch - master
* revision - 1fb2fde46c0d813ab963070668a2fd8615085281

* xbmc version - frodo


I'm more using this pull request as a check. Rarely do skins pass first request but even if I pass all checks don't publish, still like a couple days to 2x check, Just want to see where I'm at with the official requirements...


ok, initial check, round 1, done :-)

i haven't done any runtime testing yet, so i'll do that once these issues have addressed.


- addon.xml
defaultthemename="textures.xbt" > defaultthemename="Textures.xbt"
remove the BOM at the start of the file


- Remove these files:
README.md
DialogMusicScan.xml
DialogVideoScan.xml


- Missing:
pvr stuff   (optional, but recommended)
peripheral stuff   (optional, but recommended)
_screenshots folder (see: http://wiki.xbmc.org/index.php?title=Official_add-on_repository#Requirements_for_skins)
fanart.jpg   (see wiki as well)


- Invalid code:
includes.xml: <include>Global_HeadingSectionVars + !system.getbool(lookandfeel.enablerssfeeds)</include>


- Invalid Includes:
VisibleFadeEffect
SmallMusicInfo
Animation_CommonFade
cdartspin
Window_OpenClose_Animation
dialogeffect
Playing_VideoCodecFlaggingConditions
Playing_AudioCodecFlaggingConditions
Playing_AspectCodecFlaggingConditions
main_fanart_diffuse
CommonSettingsBackground
Animation_BackdropFade
SideBladeRight
Clock
Global_RSS
CommonWeatherBackground
CommonMediaPlayingBackground
ButtonMediaSubCommonValues
SideBladeLeft
CommonNowPlaying
ButtonCommonValues
CommonNowPlaying_Controls
WindowTitleCommons
WindowTitleHomeButton
BehindDialogFadeOut
WatchedOverlayShowCaseDVD
detailcolornofocus
Animation_HideShowcase
Animation_ZoomInZoomOut


- Unmatched bracket in condition:
Viewtype_Browser.xml: <animation type="Visible" reversible="false" condition="Control.HasFocus(2448))"> Viewtype_Browser.xml: <animation type="Visible" reversible="false" condition="Control.HasFocus(2448))"> Viewtype_Browser.xml: <animation type="Visible" reversible="false" condition="Control.HasFocus(2448))"> Viewtype_Browser.xml: <animation type="Visible" reversible="false" condition="Control.HasFocus(2448))">


- Non localized strings:
AddonBrowser.xml :         <label>Hide Foreign</label>
MyVideoNav.xml :         <label>More Thumbs</label>
DialogBusy.xml :         <label>Please Wait - Loading Selection</label>
DialogFullScreenInfo.xml :         <label>Time: $INFO[System.Time]</label>
DialogFullScreenInfo.xml : <label>Finish: $INFO[Player.FinishTime]</label>
DialogKaiToast.xml : <label>[B]ADDONS:[/B]</label>
DialogSeekBar.xml :         <label>Time: $INFO[System.Time]</label>
DialogSeekBar.xml :         <label>Finish: $INFO[Player.FinishTime]</label>
Home.xml :         <label>Genres</label>
Home.xml :         <label>Credits</label>
Home.xml :         <label>Last Played</label>
Home.xml :         <label>System Stats</label>
IncludesHome_Random.xml :         <label>Play Movie</label>
IncludesHome_Random.xml :         <label>Play Trailer</label>
IncludesHome_Random.xml :         <label>1 of 4</label>
IncludesHome_Random.xml :         <label>2 of 4</label>
IncludesHome_Random.xml :         <label>3 of 4</label>
IncludesHome_Random.xml :         <label>4 of 4</label>
IncludesHomeRecentlyAdded.xml :         <label>Play Movie</label>
IncludesHomeRecentlyAdded.xml :         <label>Play Trailer</label>
IncludesHomeRecentlyAdded.xml :         <label>1 of 4</label>
IncludesHomeRecentlyAdded.xml :         <label>2 of 4</label>
IncludesHomeRecentlyAdded.xml :         <label>3 of 4</label>
IncludesHomeRecentlyAdded.xml :         <label>4 of 4</label>
includes.xml :         <label> - Rated G</label> (localize 'Rated')
includes.xml :         <label> - Rated PG</label>
includes.xml :         <label> - Rated PG-13</label>
includes.xml :         <label> - Rated R</label>
includes.xml :         <label> - Rated NC-17</label>
includes.xml :         <label> - Rated UK:U</label>
includes.xml :         <label> - Rated UK:PG</label>
includes.xml :         <label> - Rated UK:12</label>
includes.xml :         <label> - Rated UK:12A</label>
includes.xml :         <label> - Rated UK:15</label>
includes.xml :         <label> - Rated UK:18</label>
includes.xml :         <label> - Rated UK:R18</label>
includes.xml :         <label> - Rated 10 ans</label>
includes.xml :         <label> - Rated 12 ans</label>
includes.xml :         <label> - Rated 16 ans</label>
includes.xml :         <label> - Rated 18 ans</label>
MyMusicNav.xml :         <label>View: $INFO[Container.ViewMode]</label>
MyMusicPlaylistEditor.xml :         <label>[B]Create Playlist[/B]</label>
MyVideoNav.xml :         <label>View: $INFO[Container.ViewMode]</label>
MyVideoNav.xml :         <label>More Thumbs</label>
SkinSettings.xml :         <label>Disable Home</label>
Viewtype_Browser.xml : <label>[B]Press Down for New Episodes[/B]</label>
Viewtype_Songs.xml :         <label>[B]SONGS[/B]</label>



if you have any questions or need help, just let me know.


cheers,
ronie
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to