On 22/02/13 12:32, Nessus wrote:
*addon -   skin.xperience-more
*version - 2.0.0
*url - git://github.com/Nessus85100/Xperience.More.git
*revision -- 2941e6d37d
*branch - master
*xbmc version -- frodo
Ronie...
Skins screenshoots are not updated yet and since I am sure there will be round 
2, I am sending this PR just to se where am I on Frodo requirements.
So... in a rare case that all are ok don't pushed yet. I will do a final PR 
when everything is in place.
Cheers
Nessus

hey Nessus,

i had a look at the skin and identified some issues that need your attention:

addon.xml:
defaultthemename="textures.xbt" > defaultthemename="Textures.xbt"
> case sensitive issue

even better would be to replace:
<extension point="xbmc.gui.skin" defaultresolution="720p" defaultresolutionwide="720p" defaultthemename="textures.xbt" effectslowdown="0.75" debugging="false"/>
with:
<extension point="xbmc.gui.skin" defaultthemename="Textures.xbt" effectslowdown="0.75" debugging="false"> <res width="1280" height="720" aspect="16:9" default="true" folder="720p"/>
</extension>


missing at the root of the skin folder:
fanart.jpg (1280x720 or 1920x1080)


_screenshots:
images need to be 1280x720


./Viewtypes_PVR.xml:2755.86: Input is not proper UTF-8!
line 2755: <label>$INFO[ListItem.StartTime]$INFO[ListItem.EndTime, ~ ]$INFO[ListItem.Genre, \95 ]</label>
> xml validation fails due to some odd character being there


./720p/MyVideoPlaylist.xml:77.20: Opening and ending tag mismatch: control line 11 and controls
> the image control is missing a </control>


media/flags/musiclabels/Var?se Sarabande.png (invalid encoding)


convert to unix EOL's:
720p/Viewtype_Playlists.xml: Mixed, predominantly Unix (LF)
720p/script-RSS_Editor-rssEditor.xml: Mixed, predominantly Windows (CRLF)


sounds.xml
contains links to several .wav files that don't exist


Pointer.xml
ERROR: Control 1 in window 10099 has been asked to focus, but it can't


MyPics.xml
22:27:38 T:140663237994368 WARNING: Trying to add unsupported control type 3


MyVideoNav.xml
22:25:19 T:140663237994368 WARNING: Trying to add unsupported control type 3
> this is due to the use of largeimage controls in several viewtypes.
> afaik these are deprecated, please use normal image controls instead


Viewtype_Posters_Spin.xml
22:25:19 T:140663237994368 ERROR: Control has invalid animation type (no condition or no type)
> check line 431


MusicVisualisation.xml
22:27:25 T:140662024419072 ERROR: GetDirectory - Error getting /home/ronie/.xbmc/addons/skin.experience-more/extras/animations/visualequ/ 22:27:25 T:140662024419072 ERROR: GetDirectory - Error getting special://skin/extras/animations/visualequ/
> case sensitive issue


Undefined Includes:
FullscreenDimensions
NewOverlay-wall-movies
NewOverlay-wall-tvshows
dialog_CommonList
dialog_CommonListItem
dialog_CommonListFocus
dialog_CommonListItemFocus
CommonClock
Viewtype_TVChannels
Viewtype_RadioChannels
Viewtype_EPGTimeline
Viewtype_EPGNowNext
Viewtype_EPGChannel
Viewtype_Recordings
Viewtype_Timers
Viewtype_Search
TopButton


Custom_DialogVisualization.xml: Unmatched parenthesis: IsEmpty(Skin.String(Vis-CustomSlideshowDir) Custom_DialogVisualization.xml: Unmatched parenthesis: !IsEmpty(Skin.String(Vis-CustomSlideshowDir) script-globalsearch-infodialog.xml: Unmatched parenthesis: substring(Container(100).ListItem.Property(MPAA),Rated G) | substring(Container(100).ListItem.Property(MPAA),USA:G script-globalsearch-infodialog.xml: Unmatched parenthesis: IsEmpty(Container(100).ListItem.Property(Album_label) | StringCompare(Control.GetLabel(3500),empty) DialogAddonSettings.xml: Unmatched parenthesis: [Window.IsVisible(TextViewer)
Includes_Animations.xml: Unmatched parenthesis: Control.HasFocus(9200


Includes_Window-Contents.xml: Undefined IDs: 62
Includes_Animations.xml: Undefined IDs: 9106
PlayerControls.xml: Undefined IDs: 9106
Includes_Animations.xml: Undefined IDs: 9102
Includes_Animations.xml: Undefined IDs: 9202


MyWeather.xml: Untranslated Label:PDA Style Icons
DialogBusy.xml: Untranslated Label:[B]LOADING PLEASE WAIT[/B]
DialogKeyboard.xml: Untranslated Label:Esc
DialogKeyboard.xml: Untranslated Label:IP Address
Includes_Window-Contents.xml: Untranslated Label:REC
DialogSlider.xml: Untranslated Label:Audio
SettingsSystemInfo.xml: Untranslated Label:lame
PlayerControls.xml: Untranslated Label:[B]XBMC Version[/B]
PlayerControls.xml: Untranslated Label:[B]Screen Resoloution[/B]
PlayerControls.xml: Untranslated Label:[B]CPU Speed (Usage)[/B]
PlayerControls.xml: Untranslated Label:[B]Memory Used[/B]
PlayerControls.xml: Untranslated Label:[B]Total Storage[/B]
PlayerControls.xml: Untranslated Label:[B]Available Storage[/B]
PlayerControls.xml: Untranslated Label:[B]IP Address[/B]
PlayerControls.xml: Untranslated Label:[B]System Uptime[/B]
Includes_Skin-Specifics.xml: Untranslated Label:Slim List
Includes_Skin-Specifics.xml: Untranslated Label:Fat List
Includes_Skin-Specifics.xml: Untranslated Label:Straight Wall
Includes_Skin-Specifics.xml: Untranslated Label:Slanted Wall
Includes_Skin-Specifics.xml: Untranslated Label:Small Frame
Includes_Skin-Specifics.xml: Untranslated Label:Small Frame
Includes_Skin-Specifics.xml: Untranslated Label:Medium Frame
Includes_Skin-Specifics.xml: Untranslated Label:Big Frame
Includes_Skin-Specifics.xml: Untranslated Label:Landscape
Includes_Skin-Specifics.xml: Untranslated Label:Landscape
Includes_Skin-Specifics.xml: Untranslated Label:Default Panels
Includes_Skin-Specifics.xml: Untranslated Label:Reversed Panels
Includes_Skin-Specifics.xml: Untranslated Label:Wide List Poster
Includes_Skin-Specifics.xml: Untranslated Label:Wide List Info
Includes_Skin-Specifics.xml: Untranslated Label:Poster
Includes_Skin-Specifics.xml: Untranslated Label:Landscape
Includes_Skin-Specifics.xml: Untranslated Label:Hide Info
Includes_Skin-Specifics.xml: Untranslated Label:Hide Info
Includes_Skin-Specifics.xml: Untranslated Label:Hide Info
Includes_Skin-Specifics.xml: Untranslated Label:Hide Info
SkinSettings.xml: Untranslated Label:Global-Custom-Folder
SkinSettings.xml: Untranslated Label:Home-Custom-Folder
SkinSettings.xml: Untranslated Label:Media-Custom-Folder
SkinSettings.xml: Untranslated Label:Programs-Custom-Folder
SkinSettings.xml: Untranslated Label:Weather-Custom-Folder
SkinSettings.xml: Untranslated Label:Weather-Custom-Folder
SkinSettings.xml: Untranslated Label:System-Custom-Folder
SkinSettings.xml: Untranslated Label:                . All Windows
SkinSettings.xml: Untranslated Label:                . Home Window
SkinSettings.xml: Untranslated Label:                . Movie Panel
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:
SkinSettings.xml: Untranslated Label:        Select Type:


if you need any help with any of these, don't hesitate to ask!


cheers,
ronie
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to