On 23/02/13 01:32, Kyle Johnson wrote:
*addon -   script.speedfaninfo
*version - 0.5.4
*url - _https://github.com/pkscout/script.speedfaninfo.git_
*revision - f9207cb42e
*branch - master
*xbmc version - Frodo

v 0.5.4
- changed display logic so percents will show even in the number of percent entries doesn't match number of speed entries
- added Galician language files
- changed over to Frodo .po language files
- updated addon.xml with new information and format for repo database


hi Kyle,

mind fixing two issues in addon.xml ?

<addon id="script.speedfaninfo"name="SpeedFan Information Display" version="0.5.4" provider-name="pkscuot">
you're missing a space there     ^

the website/forum/source/email tags should be moved to the xbmc.addon.metadata extension section.



in default.py, it might be worth to check for xbmc.abortRequested messages:
while __windowopen__ and (not xbmc.abortRequested):

this to ensure xbmc can properly and promptly exit if someone quits xbmc while the window is visible.


in xlogger.py:
            if verbose:
                xbmc.log(__log_preamble__ + ' ' + line)
            elif standard:
                xbmc.log(__log_preamble__ + ' ' + line)

i think you intended to add a loglevel there?
preferably LOGDEBUG for standard logging, to keep the xbmc.log file clean.


cheers,
ronie
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to