Could you please send a full pull request?
Thanks
Le 7 mars 2013 à 03:03, Micah Galizia <[email protected]> a écrit :
> Actually, there was a small bug with some games that I've resolved in commit
> 693fe93a if its not too late, otherwise, I can bump the version and resubmit.
>
>
> On Wed, Mar 6, 2013 at 6:43 PM, Micah Galizia <[email protected]> wrote:
>> Thanks for the review,
>>
>> I've made all recommended changes. I didn't bump the version but the new
>> commit is 24f46bfd.
>>
>>
>> On Wed, Mar 6, 2013 at 4:18 PM, Benjamin Bertrand
>> <[email protected]> wrote:
>>> 1. Missing language tag in addon.xml. See
>>> http://wiki.xbmc.org/index.php?title=Addon.xml
>>> 2. In your settings.xml you should probably put the option="hidden"
>>> for your password
>>> 3. Note that you only need the "xbmc.python" in the requires of your
>>> addon.xml. You don't really need the others.
>>>
>>> The rest looks good.
>>> You only have to fix point 1. 2 and 3 are just advices.
>>>
>>> Cheers
>>>
>>> On Wed, Mar 6, 2013 at 3:50 PM, Micah Galizia <[email protected]>
>>> wrote:
>>> > *addon - plugin.video.mlslive
>>> > *version - 1.0.0
>>> > *url - git://github.com/micahg/plugin.video.mlslive.git
>>> > *revision - 3cad0ee0
>>> > *branch - master
>>> > *xbmc version - frodo
>>> >
>>> > Hi, I've written a plugin for the MLS Live pay service. The service allows
>>> > viewers to watch live and on-demand Major League Soccer/CCL matches and
>>> > highlights.
>>> >
>>> > The service is available here: http://live.mlssoccer.com/mlsmdl
>>> >
>>> > TIA
>>> > --
>>> > "The mark of an immature man is that he wants to die nobly for a cause,
>>> > while the mark of the mature man is that he wants to live humbly for one."
>>> > --W. Stekel
>>> >
>>> > ------------------------------------------------------------------------------
>>> > Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
>>> > Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
>>> > endpoint security space. For insight on selecting the right partner to
>>> > tackle endpoint security challenges, access the full report.
>>> > http://p.sf.net/sfu/symantec-dev2dev
>>> > _______________________________________________
>>> > Xbmc-addons mailing list
>>> > [email protected]
>>> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>> >
>>
>>
>>
>> --
>> "The mark of an immature man is that he wants to die nobly for a cause,
>> while the mark of the mature man is that he wants to live humbly for one."
>> --W. Stekel
>
>
>
> --
> "The mark of an immature man is that he wants to die nobly for a cause, while
> the mark of the mature man is that he wants to live humbly for one." --W.
> Stekel
> ------------------------------------------------------------------------------
> Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
> Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
> endpoint security space. For insight on selecting the right partner to
> tackle endpoint security challenges, access the full report.
> http://p.sf.net/sfu/symantec-dev2dev
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
