On 20/03/13 09:36, Predrag Mitić wrote: > *addon - skin.quartz > *version – 4.0.8 > *url - git://github.com/pecinko/quartz.git > *revision - f038bcc3608fc61fd6ebab20361624e395dd53c1 > *branch - master > *xbmc version – frodo > > Hey Ronie, > > would you mind giving it some initial testing? > > Cheers, > Pedja
hi Pedja, i took Quartz for a test drive and bumped in to some things. as with every first pull request... the first one is the toughest, once the initial issues have been addressed, future pulls should go easy as a breeze. - all xml files have a BOM at the start, please remove it. on windows you can use this tool: http://www.bryntyounce.com/filebomdetector.htm on linux this command: sed -i '1 s/^\xef\xbb\xbf//' *.xml no idea how the batch fix it on osx tbh to avoid it in the future, set your text editor to save files as UTF-8 without BOM - change these files to have Unix style (LF) EOL's language/Chinese (Traditional)/strings.xml: Windows (CRLF) language/Serbian (Cyrillic)/strings.xml: Windows (CRLF) language/Spanish/strings.xml: Windows (CRLF) language/Italian/strings.xml: Mixed, predominantly Windows (CRLF) sounds/sounds.xml: Windows (CRLF) language/Italian/strings.xml: Mixed, predominantly Windows (CRLF) - two case sensitive issues: colors/Defaults should be colors/defaults 1080i/DialogSeekbar.xml should be 1080i/DialogSeekBar.xml - Startup.xml: <onfocus condition="IsEmpty(Window(Home).Property(Quartz_Watchlist))">RunScript(script.watchlist,$VAR[WatchlistParameters])</onfocus> the watchlist script does not exist anymore, it has been replaced by service.skin.widgets - invalid actions <onclick>-</onclick> '-' is not a valid action and will result in an error in the logfile. these can changed to <onclick>noop</onclick> (no operation) this also applies to onleft/right/up/down - non localized label DialogVideoInfo.xml: <label>Cinema</label> - Undefined Includes: ButtonInfoDialogsCommonValues (DialogPVRGroupManager.xml / DialogPVRRecordingInfo.xml) SideBladeRight (DialogPVRGroupManager.xml) Clock (DialogPVRGroupManager.xml) dialogeffect (DialogPVRRecordingInfo.xml) FlagsVideoInfo (DialogPVRGuideInfo.xml) Window_OpenClose_Animation (MyPVR.xml) - Undefined Vars: WatchlistParameters (Startup.xml) - Unmatched parenthesis (Includes_Shelf.xml) !IsEmpty(Skin.String(ShelfMovies.1.Label))] !IsEmpty(Skin.String(ShelfMovies.2.Label))] !IsEmpty(Skin.String(ShelfMovies.3.Label))] !IsEmpty(Skin.String(ShelfMovies.4.Label))] !IsEmpty(Skin.String(ShelfMovies.5.Label))] !IsEmpty(Skin.String(ShelfMovies.6.Label))] !IsEmpty(Skin.String(ShelfMovies.7.Label))] !IsEmpty(Skin.String(ShelfMovies.8.Label))] !IsEmpty(Skin.String(ShelfMovies.9.Label))] !IsEmpty(Skin.String(ShelfMovies.10.Label))] - Undefined IDs: 904 (Includes_Shelf.xml) 316 (Home.xml / Includes_Home.xml) 122 (script-XBMC-Subtitles-main.xml) 9003 (Includes_Home.xml) 9004 (Includes_Home.xml) 9005 (Includes_Home.xml) 9006 (Includes_Home.xml) if you need help with any of these, just let me know. cheers, ronie ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
