Thanks for the review, Benjamin! I've put together issues for each one and will re-send the pull request when these issues are fixed. http://github.com/RobLoach/plugin.video.jupiterbroadcasting/issues?state=open
Thanks again! Rob On Tue, May 14, 2013 at 3:35 PM, Benjamin Bertrand <[email protected]> wrote: > This is both for eden and frodo pull request: > 1. xbmc.python shall be 2.1.0 for frodo > See http://wiki.xbmc.org/index.php?title=Addon.xml#The_.3Crequires.3E_element > > 2. Due to 1, you can't have the same version number for eden and frodo > (you must have frodo version > eden version). > So 2.8.2 for eden and 2.9.0 for frodo, or something similar. > > 3. Could you please change all files to unix eol? > addonpr.addonparser - ERROR - Invalid end-of-line (CRLF) in > plugin.video.jupiterbroadcasting/addon.xml > addonpr.addonparser - ERROR - Invalid end-of-line (CRLF) in > plugin.video.jupiterbroadcasting/changelog.txt > addonpr.addonparser - ERROR - Invalid end-of-line (CRLF) in > plugin.video.jupiterbroadcasting/default.py > > 4. If possible, please fill in these optional fields: > http://wiki.xbmc.org/index.php?title=Addon.xml#Optional_information > > Thanks! > > On Tue, May 14, 2013 at 8:27 PM, Rob Loach <[email protected]> wrote: >> *addon - plugin.video.jupiterbroadcasting >> *version - 2.9.0 >> *url - git://github.com/RobLoach/plugin.video.jupiterbroadcasting.git >> *revision - a411bdd68b59b8a5940e4be2e5d70e5691058481 >> *branch - eden >> *xbmc version - eden >> *tag - 2.9.0 >> >> Changelog for 2.9.0: >> - New show: Plan B >> - Episodes per page is now a setting >> - Updated Linux Action Show thumbnail >> - Added RTSP live streaming for low quality video >> - Added audio streams >> >> -- >> Rob Loach >> http://www.robloach.net >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers complete >> security visibility with the essential security capabilities. Easily and >> efficiently configure, manage, and operate all of your security controls >> from a single console and one unified framework. Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> _______________________________________________ >> Xbmc-addons mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Rob Loach http://www.robloach.net ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
