*addon - skin.nbox
*version - 1.0.0
*url - git://github.com/niamu/skin.nbox.git
*revision - 0b69fed470
*branch - master
*xbmc version - frodo
Fixed up the issues that ronie pointed out. I hope I haven't missed
anything.
On Thu, May 16, 2013 at 4:57 PM, ronie <[email protected]> wrote:
> On 16/05/13 00:03, Brendon Walsh wrote:
>
> Sorry! Just noticed an error in that revision. Updated below.
>
> *addon - skin.nbox
> *version - 1.0.0
> *url - git://github.com/niamu/skin.nbox.git
> *revision - 6eff81b763
> *branch - official
> *xbmc version - frodo
>
>
> hey brandon,
>
> great to see another new skin is being submitted to the addon repo!
>
> as with all skins that went in before yours, there's some things that need
> to be addressed first.
> the first pull is always the hardest, but once initial issues have been
> fixed,
> subsequent pull requests should go easy as a breeze.
>
>
> here's a list of things that need your attention...
>
>
> case sensitive issues:
> addon.xml: defaultthemename="textures.xbt" >
> defaultthemename="Textures.xbt"
> DialogSeekbar.xml > DialogSeekBar.xml
> DialogOk.xml > DialogOK.xml
>
> convert all .xml files to Unix EOL's
>
> replace all occurences of <onclick>-</onclick> with <onclick>noop</onclick>
> and do the same for onleft/right/up/down
> '-' is not a valid action in xbmc and will result in errors in the logfile.
>
> nearly all the images in /media and /themes are marked as executable
> please remove the executable bit.
>
> DialogExtendedProgressBar.xml :
> ERROR: Control 31 in window 10151 has been asked to focus, but it can't
>
> MyPVR.xml:
> WARNING: Trying to add unsupported control type 3
>
> DialogVideoInfo.xml:
> ERROR: Error evaluating boolean expression !IsEmpty(ListItem.Duration) +
> SubString(ListItem.Duration,[LOWERCASE]Min[/LOWERCASE]) +
> IsEmpty(ListItem.Genre) + Container.Content(movies)
>
> Viewtype_Panel_Tall_List.xml:
> ERROR: Error evaluating boolean expression !IsEmpty(ListItem.Duration) +
> SubString(ListItem.Duration,[LOWERCASE]Min[/LOWERCASE]) +
> Container.Content(movies)
>
> Viewtype_Panel_Tall_List.xml:
> ERROR: Error evaluating boolean expression !IsEmpty(ListItem.Duration) +
> SubString(ListItem.Duration,[LOWERCASE]Min[/LOWERCASE]) +
> IsEmpty(ListItem.Director) + IsEmpty(ListItem.Tagline) +
> Container.Content(Movies)
>
> Viewtype_Panel_Tall.xml:
> ERROR: Error evaluating boolean expression !IsEmpty(ListItem.Duration) +
> SubString(ListItem.Duration,[LOWERCASE]Min[/LOWERCASE]) +
> IsEmpty(ListItem.Director) + IsEmpty(ListItem.Tagline) +
> Container.Content(Movies)
>
> Unmatched parenthesis:
> Variables.xml:
> Stringcompare(Skin.String(ItemsTypeMovies),$LOCALIZE[31739]))
>
> Variables.xml:
> Stringcompare(Skin.String(ItemsTypeMovies),$LOCALIZE[31738]))
>
> Viewtype_Episodes.xml:
> !IsEmpty(ListItem.Title) + !StringCompare(ListItem.Title, ) +
> !IsEmpty(ListItem.Art(tvshow.poster)
>
> Viewtype_Episodes.xml:
> !IsEmpty(ListItem.Title) + !StringCompare(ListItem.Title, ) +
> IsEmpty(ListItem.Art(tvshow.poster)
>
> Viewtype_Episodes_List.xml:
> StringCompare(Container.SortMethod,$LOCALIZE[20074]
>
> Viewtype_Episodes_List.xml:
> StringCompare(Container.SortMethod,$LOCALIZE[570]
>
> Viewtype_Panel_Tall_List.xml:
> [Container.Content(movies) | Container.Content(tvshows)] +
> StringCompare(Container.SortMethod,$LOCALIZE[20074]
>
> Viewtype_Panel_Tall_List.xml:
> [Container.Content(movies) | Container.Content(tvshows)] +
> StringCompare(Container.SortMethod,$LOCALIZE[570]
>
> Viewtype_Episodes_List.xml:
> !StringCompare(ListItem.Title, ) + !IsEmpty(ListItem.Art(tvshow.poster)
>
> Viewtype_Episodes_List.xml:
> !StringCompare(ListItem.Title, ) + IsEmpty(ListItem.Art(tvshow.poster)
>
> Viewtype_Episodes.xml:
> StringCompare(Container.SortMethod,$LOCALIZE[20074]
>
> Viewtype_Episodes.xml:
> StringCompare(Container.SortMethod,$LOCALIZE[570]
>
> Viewtype_Panel_Tall.xml:
> [Container.Content(movies) | Container.Content(tvshows)] +
> StringCompare(Container.SortMethod,$LOCALIZE[20074]
>
> Viewtype_Panel_Tall.xml:
> [Container.Content(movies) | Container.Content(tvshows)] +
> StringCompare(Container.SortMethod,$LOCALIZE[570]
>
>
>
> if you have any questions, or need help with this, just ask!
>
>
> cheers,
> ronie
>
------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
