Could you make an official pull request? I have a script to automate pull requests.
Make it a Zip pull, because we use git clone for git pulls (github doesn't allow git archive command). Thanks On Sun, Aug 18, 2013 at 12:33 AM, Jeppe Toustrup <[email protected]> wrote: > Again, thanks for the feedback! > > I have renamed the plugin now to plugin.video.nfl-teams and "NFL Teams" now. > Thank you for the tip regarding .gitattributes, I have added such a > file now so you can go ahead and fetch tag "v1.0.1" from the Git > repository at: https://github.com/Tenzer/plugin.video.nfl-teams.git > -- > Venlig hilsen / Kind regards > Jeppe Toustrup (aka. Tenzer) > > > On 17 August 2013 22:14, Benjamin BERTRAND <[email protected]> wrote: >> >> Le 17 août 2013 à 00:06, Jeppe Toustrup <[email protected]> a écrit : >> >>> Hi >>> >>> Thanks for the feedback. >>> I tried not to take up the name "plugin.video.nfl" in case somebody >>> makes an addon to play videos from the main NFL.com website, but >>> perhaps "plugin.video.nfl-teams" makes more sense then? >> >> Yes, this id sounds better. >> I'd use "NFL teams" or "NFL teams videos" for the name then. >> >>> >>> The categories are taken directly from the teams websites, that's why >>> the selection varies for each team. Since the content always will be >>> in English, I thought it wouldn't make much sense to make the category >>> names translate-able. >>> >> >> It's always nice to be able to translate the strings. >> But I agree that for most categories of this addon, it probably doesn't make >> much sense to translate them. >> And as the content is in English only, it's fine like that with me. >> >>> >>> I want to have the SVG files in the Git repository in case I need to >>> make some changes to the graphics at a later point, but there's no >>> need to include them in the distributed zip file as they aren't used >>> by the addon while running. >> >> Just in case you don't know about it: you can use .gitattributes to exclude >> files from git archive. >> >> beenje >> >>> -- >>> Venlig hilsen / Kind regards >>> Jeppe Toustrup (aka. Tenzer) >>> >>> >>> On 16 August 2013 23:47, Martijn Kaijser <[email protected]> >>> wrote: >>>> plugin.video.nfl-videos already speaks for itself that it's for video so >>>> might as well make it plugin.video.nfl >>>> >>>> normally all used string in the addon must be translatable like you used >>>> for >>>> "catagories". >>>> not sure how feasible that will be doing that for all of them. perhaps at >>>> least do it for the most common ones. >>>> >>>> to exclude file you can add a .gitignore file to "hide" the files you >>>> don't >>>> want in a plugin. ie the SVG files >>>> https://help.github.com/articles/ignoring-files >>>> >>>> @Beenje >>>> your thoughts on the strings? >>>> >>>> Martijn >>>> >>>> >>>> On Fri, Aug 16, 2013 at 11:23 PM, Jeppe Toustrup <[email protected]> wrote: >>>>> >>>>> Hi >>>>> >>>>> I've made a new addon which can play videos from all the various >>>>> football teams' websites. I have a public Git repository for the code, >>>>> but since it contains some SVG files for the graphics used in the >>>>> addon, I thought I instead would point you to a zip file where those >>>>> files has been left out. >>>>> >>>>> *addon - plugin.video.nfl-videos >>>>> *version - 1.0.0 >>>>> *url - >>>>> https://github.com/Tenzer/plugin.video.nfl-videos/releases/download/v1.0.0/plugin.video.nfl-videos-v1.0.0.zip >>>>> *xbmc version - frodo >>>>> >>>>> Let me know if there's anything I need to change before the addon will >>>>> be accepted. >>>>> >>>>> -- >>>>> Venlig hilsen / Kind regards >>>>> Jeppe Toustrup (aka. Tenzer) >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Get 100% visibility into Java/.NET code with AppDynamics Lite! >>>>> It's a free troubleshooting tool designed for production. >>>>> Get down to code-level detail for bottlenecks, with <2% overhead. >>>>> Download for free and get started troubleshooting in minutes. >>>>> >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk >>>>> _______________________________________________ >>>>> Xbmc-addons mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >>>> >>>> >>>> >>>> >>>> -- >>>> regards, >>>> Martijn Kaijser >>>> Team XBMC >>> >>> ------------------------------------------------------------------------------ >>> Get 100% visibility into Java/.NET code with AppDynamics Lite! >>> It's a free troubleshooting tool designed for production. >>> Get down to code-level detail for bottlenecks, with <2% overhead. >>> Download for free and get started troubleshooting in minutes. >>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> Xbmc-addons mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
