On 08/31/2013 04:51 PM, Predrag Mitić wrote:
> Hey Ronie
>
> could you run your usual main repo compatibility test on Amber?
>
> We have fixed all that we were able to find but I'm sure something will still 
> be missing.
>
> Cheers Peca
>
> url:  https://github.com/pecinko/skin.amber.git
> rev: 10da7a5a013fae32b726eb61f2a156a003b135fd
> branch: master
>

hi Predrag,


here's what i could find....


remove this file:
_V_VideoOSD.xml


remove the BOM at the start of this file:
language/Portuguese/strings.xml


convert all .xml files to have Unix style EOL's


nearly all files (outside the 1080i folder) are marked as executable,
you need to remove the executable bit on those files


missing _screenshots folder (max. 10 1280x720 .jpg screenshots)


non-localized strings:
Settings.xml:                <label>PVR</label>


Unmatched parenthesis:
MyMusicNav.xml: <visible>!IsEmpty(ListItem.Art(fanart)</visible>
MyMusicNav.xml: <visible>IsEmpty(ListItem.Art(fanart)</visible>
MyMusicNav.xml: <visible>!IsEmpty(ListItem.Art(fanart)</visible>
MyVideoNav.xml: <visible>!IsEmpty(ListItem.Art(fanart)</visible>
Includes_Shelf_Contents.xml: 
<visible>![IsEmpty(Window(Home).Property(RecommendedMovie.1.Title)) + 
IsEmpty(Window(Home).Property(RandomMovie.1.Title))]]</visible>


Undefined IDs:
Includes_Horizontal_Home.xml: <onclick>ActivateWindow(1112)</onclick>
Includes_Variables.xml:    <value 
condition="Window.IsActive(1112)">$LOCALIZE[31976]</value>


if you have any questions, or need help, just ask :-)


cheers,
ronie

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to