On 25 Nov 2013 16:29, "FAST COLORS" <[email protected]
<mailto:[email protected]>> wrote:
Hi, thank you much for the help..
here's what I've been sending to the mailing list, I tried from
this address which is the one I've submitted to the mailing list
with...
addon - skin.sio2
version - 2.2.5
url - git://github.com/fastcolors/skin.sio2.git
revision - 78bdcaf1979c8767b5fd4a96ae7cf07a99c62d0a
branch - FRODO
xvmc version - FRODO
hey fastcolors,
thanx for submitting your skin to the repo.
almost nice to see a new skin come to completion :-)
as i tell everyone (and was told myself 5 years ago when i submitted my
skin),
the first pull request is always the most difficult one.
there will be quite a few things that need to be addressed, and it may take
multiple rounds to get everything in order. but once that initial hurdle
is taken,
any subsequent pull will go easy as a breeze.
here's what i came up with during my first round of checkups...
first, there's a few definite no-go's in the skin:
- when i go to 'music > add source' to add my mp3's,
the skin tells me i should install the xbmchub fusion repo ???
(encouraging users to install third party repos is something we prefer
to avoid anyway)
- putting access to 'skin settings' behind a script is not the right way
forward imo.
i think this needs to be addressed in xbmc itself.
currently the xbmc 'lock settings' option applies to all settings
sections accept for skin settings.
i would agree this option should also apply to skin settings as well.
as for the rest...
remove the BOM at the start of all xml files,
if you develop on window, this will be a handy tool:
http://www.bryntyounce.com/filebomdetector.htm
several files are marked as executable, so please remove the exectutable
attribute on these:
./1080i/CustomDialogButtonMenu.xml
./1080i/Home.xml
./1080i/Custom_Settings.xml
./language/English/strings.po
./addon.xml
./media/* (most images in there)
addon.xml
- remove the non-localized <description> at line 19
- use this xbmc.gui.skin extention format:
<extension point="xbmc.gui.skin" defaultthemename="Textures.xbt"
effectslowdown="1" debugging="false">
<res width="1920" height="1080" aspect="16:9" default="true"
folder="1080i"/>
</extension>
remove the language/English/strings.xml file (you already have a
strings.po file there)
rename 1080i/DialogSeekbar.xml to 1080i/DialogSeekBar.xml
(case sensitive issue, xbmc fails to load the file on case sensitive
systems, like linux)
these xml files don't validate:
./PVRviews.xml:265.29: attributes construct error
<focusedlayout width="802 "height="81">
(fix the space there)
./LockSettings.xml:2.6: XML declaration allowed only at the start of the
document
<?xml version="1.0" encoding="UTF-8"?><window id="131">
(remove the empty line at the start of the file)
./CBrowseskin.xml:2.6: XML declaration allowed only at the start of the
document
<?xml version="1.0" encoding="UTF-8"?><!--NAVI X-->
(remove the empty line at the start of the file)
change:
<onclick>-</onclick> to <onclick>noop</onclick>
'-' is not a valid action in xbmc, and will lead to errors in the log.
the same applies to onleft/right/up/down
Undefined Includes:
dialogeffect
ListBG
Dialogbuttons
BlackBackgroud
MusicBackground
Undefined Vars:
Trailer
Includes_Variables.xml: Unmatched parenthesis:
IsEmpty(ListItem.Art(fanart) | Container.Content(Albums) |
Container.Content(episodes)
Musicviews.xml: Unmatched parenthesis:
!IsEmpty(ListItem.Property(Artist_Disbanded)
Programviews.xml:Unmatched parenthesis:
!IsEmpty(ListItem.Property(Artist_Disbanded)
Undefined IDs:
1717
59
356
Non-localized strings:
Custom_remselect.xml: Untranslated Label:Plugins
Custom_remselect.xml: Untranslated Label:Repositories
Custom_remselect.xml: Untranslated Label:Programs
Custom_remselect.xml: Untranslated Label:Skins
CustomAddonShelfcustomizer.xml: Untranslated Label:Shelf Addons
PVRviews.xml: Untranslated Label:DATE
DialogButtonMenu.xml: Untranslated Label:Timer
CustomDialogButtonMenu.xml: Untranslated Label:Timer
FileManager.xml: Untranslated Label:GO BACK TO ADDONS AND SELECT
"INSTALL FROM ZIP FILE" SELECT "FUSION" AND INSTALL ANY REPOSITORIES
YOU'D LIKE TO!
Custom_Watchlist.xml: Untranslated Label:Watchlists
Custom_Watchlist.xml: Untranslated Label:STARTED MOVIES
Custom_Watchlist.xml: Untranslated Label:NEXT EPISODES
Custom_Watchlist.xml: Untranslated Label:TOP ALBUMS
DialogContextMenu.xml: Untranslated Label:Cinema
Customrssmiss.xml: Untranslated Label:To access RSS feeds You need
install the script "RSS CLIENT STANDALONE" - In order to do so You must
add the pieh Add-on Repository by downloading the zip file and selecting
Add-ons, Install from zip file. LINK:[CR]
https://github.com/downloads/pieh/pieh-xbmc-addons/repository.pieh.zip
Customrssmiss.xml: Untranslated Label:CLOSE
DialogVideoInfo.xml: Untranslated Label:MPAA:
Home.xml: Untranslated Label:WatchList
CustomHomeCustomizer.xml: Untranslated Label:Watchlist
CustomHomeCustomizer.xml: Untranslated Label:Watchlist
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:addon
CustomHomeCustomizer.xml: Untranslated Label:script
CustomHomeCustomizer.xml: Untranslated Label:script
CustomHomeCustomizer.xml: Untranslated Label:script
CustomHomeCustomizer.xml: Untranslated Label:script
CustomHomeCustomizer.xml: Untranslated Label:script
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:favourite
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Addon
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Script
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:Favourite
CustomHomeCustomizer.xml: Untranslated Label:[B]Favourite Options[/B]
CustomHomeCustomizer.xml: Untranslated Label:Current Location:
CustomHomeCustomizer.xml: Untranslated Label:SETTINGS
that'll be all for now ;-)
should you have any questions or need help, just ask!
cheers,
ronie
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
