guess that pluginpath was in the redundant code you removed :)
Could you perhaps make the description in the addon.xml a bit more
extensive?
http://forum.xbmc.org/showthread.php?tid=160975&pid=1567454#pid1567454
Makes it a bit easier for users to understand what this addon is all about
if they don't know SI
regards,
Martijn Kaijser
Team XBMC
On Fri, Dec 6, 2013 at 10:52 PM, scotty roscoe <[email protected]>wrote:
> *addon - plugin.video.si
> *version - 1.1.0
> *url - https://github.com/learningit/plugin.video.
> <https://github.com/learningit/plugin.video.wsj>si
> *revision - a59440b6c1d61f9ff10a2b9f8d4dabfb4f06821c
> *branch - master
> *xbmc version - frodo
>
>
> Sorry that first one was a total screw up in the repo. Have remove all the
> separate modules and deleted extraneous files - a lot of baggage for 8
> lines of code.
> I don't quite understand your comment about pluginpath. I only use the
> path to retrieve the icon and fanart for the addon, there is nothing
> written to it that I see.
>
>
> On Fri, Dec 6, 2013 at 3:29 PM, Martijn Kaijser <[email protected]> wrote:
>
>> to start with the following libs are available as modules from xbmc repo
>> and should be added as dependency and imported as such:
>> bs4
>> pyamf
>> simplejson
>>
>> You use the pluginpath for storing information. This is not allowed and
>> the profile path should be used.
>>
>> xbmc.translatePath(xbmcaddon.Addon().getAddonInfo('profile')).decode('utf-8')
>>
>>
>> also throughout the code i found things that have nothing to do with this
>> addon and are copied from
>>
>> "plugin.video.free.cable-beta"
>>
>> or something. Please clean up as this makes reviewing the code a lot of
>> work and imo not acceptable as such.
>> Like
>> https://github.com/learningit/plugin.video.si/blob/master/resources/lib/_common.py
>> has almost nothing to do with this addon.
>>
>>
>> As a separate note:
>> if would also be better if the other libs are made separate modules as
>> well: html5lib and dns (if they are still needed)
>>
>> regards,
>> Martijn Kaijser
>> Team XBMC
>>
>>
>>
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Xbmc-addons mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>
>>>
>>
>
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
