Okay with most of these.
9. httplib2 should be submitted as a separate module so it could be
re-used. Note that you might want to use requests instead
(it's already part of xbmc repo). See
http://www.python-requests.org/en/latest/community/faq/
Will you let this one slide temporarily? I plan to move back to httplib for
other reasons soon.
10. You use script.common.plugin.cache. You should add a dependency in
your addon.xml
I must be using this unintentionally? What is the import you are seeing?
Thanks,
Chris
P.S. Apologies if discussion of these matters on the list is not
appropriate.
On Wed, Dec 18, 2013 at 3:49 PM, Benjamin Bertrand <
[email protected]> wrote:
> 1. Addon id should be lowercase. It's ok in your addon.xml but not in
> you pull request.
>
> 2. Please add a language tag (see
> http://wiki.xbmc.org/index.php?title=addon.xml#.3Clanguage.3E) and
> other extra tags license, forum, website... See
> http://wiki.xbmc.org/index.php?title=addon.xml#Required_elements
>
> 3. You can remove the minversion
>
> 4. Incorrect icon.png size. It should be 256x256.
>
> 5. You have invalid xml in your settings.xml:
> plugin.video.XBMB3C/resources/settings.xml: not well-formed (invalid
> token): line 5, column 61
> '<' and '>' shall be replaced with '<' and '>'
>
> 6. Please remove the _screenshots directory. It doesn't add much value
> for a plugin and make the zip to download much bigger.
>
> 7. removed_plex_code_for_reference.py is not used. It shouldn't be
> part of the addon
>
> 8. If possible replace "print" with "xbmc.log()"
>
> 9. httplib2 should be submitted as a separate module so it could be
> re-used. Note that you might want to use requests instead
> (it's already part of xbmc repo). See
> http://www.python-requests.org/en/latest/community/faq/
>
> 10. You use script.common.plugin.cache. You should add a dependency in
> your addon.xml
>
> 11. You might want to add a disclaimer tag in your addon.xml to
> explain that Aeon Nox is required for all features to work
>
> On Mon, Dec 16, 2013 at 1:10 AM, Chris Nappi <[email protected]> wrote:
> > [with correct git usage (third times a charm?)]
> >
> > *addon - plugin.video.XBMB3C
> > *version - 0.5.5
> > *url - https://github.com/xnappo/plugin.video.XBMB3C.git
> > *revision - 0.5.5
> > *tag - 0.5.5
> > *xbmc version - frodo
> >
> > Thanks,
> > Chris
> >
> >
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Rapidly troubleshoot problems before they affect your business. Most IT
> > organizations don't have a clear picture of how application performance
> > affects their revenue. With AppDynamics, you get 100% visibility into
> your
> > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> > Pro!
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Xbmc-addons mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
> >
>
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
