|
Hi sphere, Thanks a lot for the help and the hint. I've considered for a long time/testing in the past to replace the conditional "print" sentence located into the "log()" and "_log()" functions at lutil.py by "xbmc.log()". Both functions are only used upon debug settings option is activated (from the add-on's settings menu), and that option is always disabled by default (i.e. the debug option is only activated under testing, or in case some issue must be reported by the user to the add-on developer); under normal conditions, the add-on is completely quiet and doesn't write a single line into any log file. On the other hand, the lutil.py file is used in all the add-ons i maintain as a base tools library to normalize the coding process. You can see from your pull request made this morning that this is the same file copied from the "plugin.video.esa" in the official repo. Besides of that, my willing in a medium term is to adapt the add-ons code to work with automatic testing (i.e travis-ci), so to work with unit testing outside the XBMC environment i should keep the scrapers code apart from the code that uses the XBMC API function calls. That's another reason to keep the conditional print sentence into the lutil.py "log()" functions. Please, consider my explanations to preserve them in future PRs. That's not a chance nor a neglect result, i promise. BTW, congratulations for officially joining the XBMC Team! I'm glad to see you around :-) Best regards, jamontes. -------- Original Message --------
Subject: Re: [Xbmc-addons] [Git Pull] plugin.video.eso v1.0.0 (Frodo) - New From: Tristan Fischer <[email protected]> To: José Antonio Montes <[email protected]> CC: xbmc-addons <[email protected]> Date: Mon, 17 Feb 2014 08:23:58 +0100
|
------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
