Hi everybody,
I think i fixed the issues pointed out by Ronie. The latest commit is:
59cd4fd7f2.
For me it’s ok to include the skin in Gotham repo only.
My forum account is “Tgxcorporation”. Is there a place in the forums where i
can introduce myself?
Regarding the skin dev repo, i feel the skin is pretty much mature for a 1.0
release and i would prefer to include it in the normal Gotham repo. But if you
think or prefer it should start from the dev repo, no problem from my side.
Thanks a lot!
Tgx
18 febbraio 2014 at 08:33:59, Martijn Kaijser ([email protected]) ha scritto:
maybe to add, has this been through some user testing?
in general we don't like developers requesting updates every few days or so
because people find certain issues that need to be fixed.
Maybe our skin dev repo might be a good start to get some initial user feedback
or just create some .zip for people to install and try it out.
http://forum.xbmc.org/showthread.php?tid=159372
Of course it's up to ronie if he thinks this could go straight to normal Gotham
repo.
and also nice to see a new skin popping up :)
regards,
Martijn Kaijser
Team XBMC
On Tue, Feb 18, 2014 at 12:43 AM, ronie <[email protected]> wrote:
On 17-02-14 15:20, Massimo Pagani wrote:
*addon - skin.blackglassnova
*version - 1.0.0
*url - git://github.com/Tgxcorporation/skin.blackglassnova.git
*revision - 9b9f84b71f
*branch - master
*xbmc version - frodo, gotham
Hi everybody,
this is my first skin for XBMC.
I recently switched from MediaPortal to XBMC and i’m happy to port my skins to
XBMC.
I used Amber and Confluence skins as code starting point. The skin supports
Plexbmc.
Hope you like it!
Tgx
hi Tgx,
thanx a bunch for submitting your skin to our addon repo!
as with every new submission, there's a few initial issues that need to be
ironed out before we can push to our repo.
since your skin is gotham compatible, i assume you're aiming for the gotham
skin repo.
should you also want to include it in our frodo repo (since you mentioned both
in your request),
you'd have to create a separate version of your skin, with all the gotham
specific functionallity removed.
there's a few minor issues with the skin that would need some attention:
1) it's missing a '_screenshots' folder.
see: http://wiki.xbmc.org/index.php?title=Add-on_rules#Requirements_for_skins
2) in your english strings.po you might want to remove the references to the
amber skin at the top of the file
3) pretty much all of the files included in your skin are marked as executable.
since we're not going to execute xml or image files, please remove the
executable bit on all files
4) case-sensitive issue:
you have a media/topbar folder, but use Topbar/...png in your xml files
5) Includes_Shelf_Contents.xml - Undefined Include:
Recommended_Header
6) CustomMoviesHomeButton.xml - Unmatched parenthesis:
IsEmpty(Skin.String(movie_entries)) + IsEmpty(Skin.String(CustomMovie.1.Path)
7) Includes_Horizontal_Home.xml - Unmatched parenthesis:
IntegerGreaterThan(Container(9001).NumItems,0
8) music library:
- i can't switch to filemode
- big panel viewmode can't be selected (it switches back to list view)
should you have any questions on these, or need help, don't hesitate to ask!
btw. do you have a xbmc forum account?
if so, mind telling me your username, i'd like to set up a support section for
your skin
on our forum once we push your skin to the addon repo.
cheers,
ronie
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
