Hi Wayne,
you are right with default.py - our check script mis-interpreted your code
there (print_exc() != print). It is ok to leave it like it is now.
It is also OK to use print if you need it for e.g. (non xbmc) testing -
like you do.
I will add a whitelist functionality to our script to avoid such requests
in these special cases.
However, print/log related issues are cosmetics (if this would be the only
issue I would have accepted your PR with a reminder for next PR). You
should decide if this is worth a separate release ;)
regards,
sphere
2014-03-12 20:05 GMT+01:00 Wayne Davison <[email protected]>:
> I don't see any prints in default.py unless you mean the use of
> print_exc() (which has been around for quite a while). I can remove those
> 2 calls, if desired. The other libraries only have prints in the __main__
> code path, which is only used for testing or timezone-code update assisting
> (so logging those would not work). Is there some way to signal this
> non-xbmc use of print to your (presumed) checking scripts so that that
> don't get flagged? Maybe I should switch them to sys.stdout.write() to
> avoid future confusion? I think I'll go ahead and do that...
>
> I'll tweak the other mentioned things for my upcoming release -- thanks
> for pointing them out. For this particular release I was under the
> impression that you guys wanted a quick reduced-debug logging change, so
> that's why I made 216eec8ed09ff2cba49084a50efcf887760f9a36 available. If
> you don't want it just yet, that's fine by me -- I can just release 6.0.5
> as a feature release a little later on (once the new code has stabilized)
> and you can ignore this request for now.
>
> ..wayne..
>
>
> On Wed, Mar 12, 2014 at 1:48 AM, Tristan Fischer <[email protected]> wrote:
>
>> Hi,
>>
>> sorry for the delay!
>>
>> There are some issues which need to be addressed:
>> - Incorrect icon.png size: 250x250 (256x256 required)
>> - Missing required license tag
>> - Invalid string id 450
>> - No xml encoding specified in
>> script.tv.show.next.aired/resources/skins/Default/720p/script-NextAired-TVGuide.xml
>>
>> Also, these are optional but recommended:
>> - Missing optional website tag
>> - Missing optional email tag
>> - script.tv.show.next.aired/default.py: print statement should be
>> replaced with xbmc.log()
>> - script.tv.show.next.aired/resources/lib/country_lookup.py: print
>> statement should be replaced with xbmc.log()
>> - script.tv.show.next.aired/resources/lib/fanarttv.py: print statement
>> should be replaced with xbmc.log()
>> - script.tv.show.next.aired/resources/lib/next_aired_dialog.py: print
>> statement should be replaced with xbmc.log()
>>
>> regards,
>> sphere
>>
>>
>>
>>
>> 2014-03-07 22:20 GMT+01:00 Wayne Davison <[email protected]>:
>>
>>> *addon - script.tv.show.next.aired
>>> *version - 6.0.5
>>> *url - https://github.com/WayneD/script.tv.show.next.aired.git
>>> *revision - 216eec8ed09ff2cba49084a50efcf887760f9a36
>>> *branch - master
>>> *xbmc version - Frodo, Gotham
>>>
>>> This version is mainly to reduce the level of debug logging that the
>>> script outputs. It also has a change to allow the background process
>>> to start up a replacement when it notices that the version changed
>>> (instead of only stopping the old script, which had left the user w/o
>>> background updating).
>>>
>>> This should hopefully be the last change for a while since things seem
>>> to have stabilized.
>>>
>>> ..wayne..
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Subversion Kills Productivity. Get off Subversion & Make the Move to
>>> Perforce.
>>> With Perforce, you get hassle-free workflows. Merge that actually works.
>>> Faster operations. Version large binaries. Built-in WAN optimization
>>> and the
>>> freedom to use Git, Perforce or both. Make the move to Perforce.
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Xbmc-addons mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>
>>
>>
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
