Hi,

- you have an invalid string ID (24000, scripts need to have strings in
range 32xxx)
- you have included bs4 (beautifulsoup v4) which is available as xbmc
module, please remove it from your repo and require xbmc's module instead
- please delete all .pyo (and .pyc) files and add (after the delete commit)
add them to your .gitignore
- gotham addons need to require xbmc.python 2.14.0
 - service.subtitles.subsfactoryit/service.py: print statement should be
replaced with xbmc.log()

Please fix the issues above and send another PR.

regards,
sphere


2014-03-29 23:21 GMT+01:00 Andrea Cotza <[email protected]>:

> Hi,
> This is my subtitle addon for subs factory.it
>
> *addon -   service.subtitles.subsfactoryit
> *version - 1.0.0
> *url - https://github.com/CotzaDev/service.subtitles.subsfactoryit
> *revision - b1c5d97b8f6899864f9d8a1d3bfb2152ed39ecd0
> *branch - master
> *xbmc version - gotham
>
>
> Thanks a lot and best regards,
>
> cotzadev
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to