Hi,

there are some issues which need to be fixed before I can pull:
- Missing LICENSE.txt file
- Given addon id doesn't match plugin.video.drundoo
- Invalid version for xbmc.python (2.7.3 != 2.1.0)
- xbmc.addon.repository extension point is not allowed
- plugin.video.oodnurdtv/addon.pyc is not allowed
- plugin.video.oodnurdtv/resources/.DS_Store is not allowed
- plugin.video.oodnurdtv/resources/__init__.pyc is not allowed
- plugin.video.oodnurdtv/resources/drundoo.pyc is not allowed
- Missing license tag
- All visible strings need to be translatable

These issues are optional but recommended:
- Missing optional forum tag
- Missing optional website tag
- Missing optional source tag
- Missing optional email tag
- plugin.video.oodnurdtv/resources/drundoo.py: print statement should be
replaced with xbmc.log()

Also, is it really required that you call the player directly? Plugins
should use playable Listitems and/or setResolvedUrl. There are exceptions
but I don't see a reason for not using setResolvedUrl in your case.

regards,
sphere


2014-03-30 18:58 GMT+02:00 Peter Raev <[email protected]>:

> *addon - oodnurdtv
> *version - 0.0.1
> *url - git://github.com/pesheto/plugin.video.oodnurdtv.git
> *revision - 88c09e1a42
> *branch - master
> *xbmc version - frodo
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to