ok some issues found
icon.png needs to be 256x256
any text used as label needs to be added to strings.po so it can be
translated.
See
http://wiki.xbmc.org/index.php?title=Add-on_structure#resources.2Flanguage.2F
and
http://mirrors.xbmc.org/docs/python-docs/12.2-frodo/xbmcaddon.html#Addon-getLocalizedString

>From a quick look you only use them in the settings.xml and several time in
a dialog like here
https://github.com/powlo/weather.metoffice/blob/master/src/metoffice/setlocation.py#L70
(log messages can stay English)



regards,
Martijn Kaijser
Team XBMC


On Sat, Apr 5, 2014 at 4:01 PM, Paul Backhouse
<[email protected]>wrote:

>  On 04/04/14 22:24, Martijn Kaijser wrote:
>
>  incomplete PR.
> need more info as stated on the wiki.
>
>
> My apologies.
>
>  *addon -   weather.metoffice
>  *version - 1.0.0
>  *url - git://github.com/powlo/weather.metoffice.git
>  *revision - af52bf5d55827d30480db3e4612579ca3cdd577c
>  *branch - master
>  *xbmc version - frodo
>
>
>  and from quick look your dependencies don't match in addon.xml
>
>
> I'm not sure what you mean. I've bumped *up* the versions for xbmc.python
> and script.module.pytz. This seems fairly cosmetic.
>
> Are there missing packages? The only non-standard package I can see is
> pytz and this is a declared dependency.
>
> Paul
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees_APR
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to