On 05-05-14 10:23, Kib wrote:
*addon - skin.neon
*version - 3.0.3
*url - https://github.com/kibje/skin.neon <https://github.com/kibje/skin.neon>
*revision - 1d8ea8ba369a261e81cad7dd49f3cd12ecb94a40
*branch - Gotham
*xbmc version - gotham

Hey guys,

After a lot of work we got Neon to a state where I believe it is ready to be included in the official repo. I would like to make sure we pass all required checks and then do the real request in a few days to make sure we bump it with a slightly higher number than currently in staging.

Would you mind checking to see if it would be allowed in in the state referenced above?
Obviously no hurry.

Cheers,

Ejal  (Kib)

hey Ejal,


here's a list of issues that need your attention:

please cleanup sounds folder, there are quite a few unused wav/mp3 files in there

the screenshots in the _screenshots folder need to be 1280*720px

remove this file:
skin.neon/media/dialogs/osd_volume.pdn

fix or remove this file (filename has an invalid encoding):
skin.neon/media/extras/Studios/Film i V?st.png

these files start with a BOM, please remove it:
./720p/Viewtype_PanelLandscape.xml
./720p/SlideShow.xml
./720p/MyVideoPlaylist.xml
./720p/Viewtype_Multiplex.xml
./720p/DialogButtonMenu.xml
./720p/TrainerSettings.xml
./720p/VideoFullScreen.xml
./720p/MyPics.xml
./720p/Custom_Overlay.xml
./720p/MyPVR.xml
./720p/Viewtype_Coverflow2.xml
./720p/DialogTextViewer.xml
./720p/DialogFileStacking.xml
./720p/Includes.xml
./720p/Viewtype_16x9.xml
./720p/DialogVideoInfo.xml
./720p/MusicOSDVisSettings.xml
./720p/MyMusicPlaylist.xml
./720p/Home.xml
./720p/DialogButtonMenu-lower.xml
./720p/DialogMuteBug.xml
./720p/MusicVisualisation.xml
./720p/MyMusicNav.xml
./720p/DialogGamepad.xml
./720p/DialogYesNo.xml
./720p/MyMusicSongs.xml
./720p/DialogVolumeBar.xml
./720p/DialogAlbumInfo.xml
./720p/Viewtype_Poster.xml
./720p/DialogScriptInfo.xml

Undefined Includes:
custom_DialogFavourites.xml: <include>CommonFileCount2</include>

don't specify a <defaultcontrol> in Pointer.xml



if you have any questions or need help, just let me know!


cheers,
ronie
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to