Thanks, added to frodo repository! regards, sphere
2014-07-08 21:06 GMT+02:00 José Antonio Montes <[email protected]>: > Hi sphere, > > That's right. I'm really sorry to skip that :-( > > OK, so here it is the good one: > > > * addon - plugin.video.filmsforaction > * version - 1.0.1 > * url - git://github.com/jamontes/plugin.video.filmsforaction.git > * revision - cb4f35d4c85783f671c3cd19e6a37183bb0945b5 > > * branch - master > * xbmc version - frodo > > > Changelog (Frodo) > 1.0.1 > - Added mail tag into addon.xml file. > - Added settings.xml encoding line. > - Modified add-on logging system according to recommendations. > - Modified categories parser due to website changes. > 1.0.0 > - Fixed Vimeo custom scraper due to API change. > - Modified video list parser due to website changes. > - Added support for SnagFilms videos thanks to the SnagFilms add-on > (credits: t1m) > - Updated version number for official repo bump. > 0.1.0 > - Remove the Vimeo add-on dependency due to a problem found running on > Gotham. > - Made custom Vimeo scraper to support the Vimeo videos on Gotham. > - Added forum thread to addon and README files. > 0.0.9 > - Clean up code and documentation. > - prepare everything for first bump into git repo. > > > Thanks a lot for all your help and best regards, > > > jamontes. > > -------- Original Message -------- > Subject: Re: [Xbmc-addons] [Git Pull] plugin.video.filmsforaction v1.0.1 > (Frodo) - New > From: Tristan Fischer <[email protected]> > To: José Antonio Montes <[email protected]> > CC: xbmc-addons <[email protected]> > Date: Tue, 8 Jul 2014 10:16:00 +0200 > >> >> Hi, >> >>> I've added the mail tag, and replaced the prints statements with >>> xbmc.log() into plugin.py. However, i kept the print statements into >>> lutil.py, as this module is only used by the website api parser (i.e. >>> ffa_api.py) run outside the XBMC enviroment for testing purposes, and the >>> default config into the add-on settings is "no debug" (i.e. completely >>> quiet). So i decided to use "xbmc.log()" for the XBMC related part (i.e. >>> default.py and plugin.py), and "print" for the website parser part (i.e. >>> ffa_api.py and lutil.py). >> >> >> Thats totally OK. >> >> everything else fixed, well done. >> >> But now you have a inconsistency in the version numbers, you requested >> and your changelog says 1.0.1 but your addon.xml says 1.0.0. >> >> regards, >> sphere >> >> 2014-07-03 22:43 GMT+02:00 José Antonio Montes <[email protected]>: >>> >>> Ops!! I missed the XML encoding line! >>> >>> Thanks for pointing that :-) >>> >>> I've added the mail tag, and replaced the prints statements with >>> xbmc.log() >>> into plugin.py. However, i kept the print statements into lutil.py, as >>> this >>> module is only used by the website api parser (i.e. ffa_api.py) run >>> outside >>> the XBMC enviroment for testing purposes, and the default config into the >>> add-on settings is "no debug" (i.e. completely quiet). So i decided to >>> use >>> "xbmc.log()" for the XBMC related part (i.e. default.py and plugin.py), >>> and >>> "print" for the website parser part (i.e. ffa_api.py and lutil.py). >>> >>> So here is the new PR info: >>> >>> * addon - plugin.video.filmsforaction >>> * version - 1.0.1 >>> * url - git://github.com/jamontes/plugin.video.filmsforaction.git >>> * revision - 23ece63280d1f5d89c361af854efe86b14b8d501 >>> * branch - master >>> * xbmc version - frodo >>> >>> >>> Changelog (Frodo) >>> 1.0.1 >>> - Added mail tag into addon.xml file. >>> - Added settings.xml encoding line. >>> - Modified add-on logging system according to recommendations. >>> - Modified categories parser due to website changes. >>> 1.0.0 >>> - Fixed Vimeo custom scraper due to API change. >>> - Modified video list parser due to website changes. >>> - Added support for SnagFilms videos thanks to the SnagFilms add-on >>> (credits: t1m) >>> - Updated version number for official repo bump. >>> 0.1.0 >>> - Remove the Vimeo add-on dependency due to a problem found running on >>> Gotham. >>> - Made custom Vimeo scraper to support the Vimeo videos on Gotham. >>> - Added forum thread to addon and README files. >>> 0.0.9 >>> - Clean up code and documentation. >>> - prepare everything for first bump into git repo. >>> >>> >>> Thanks a lot for the help and best regards, >>> >>> jamontes. >>> >>> -------- Original Message -------- >>> Subject: Re: [Xbmc-addons] [Git Pull] plugin.video.filmsforaction v1.0.0 >>> (Frodo) - New >>> From: Tristan Fischer <[email protected]> >>> To: José Antonio Montes <[email protected]> >>> CC: xbmc-addons <[email protected]> >>> Date: Thu, 3 Jul 2014 11:00:57 +0200 >>> >>>> >>>> Hi, >>>> >>>> there are some issues which need to be fixed before I can accept your >>>> PR: >>>> - No xml encoding specified in >>>> plugin.video.filmsforaction/resources/settings.xml >>>> >>>> It would also be nice if you could have a look to these recommendations: >>>> - Missing optional email tag (just add an empty one if you don't want >>>> to publish your email) >>>> - plugin.video.filmsforaction/resources/lib/lutil.py: print statement >>>> should be replaced with xbmc.log() >>>> - plugin.video.filmsforaction/resources/lib/plugin.py: print statement >>>> should be replaced with xbmc.log() >>>> >>>> please fix them and send a new PR. >>>> >>>> regards, >>>> sphere >>>> >>>> 2014-07-02 23:58 GMT+02:00 José Antonio Montes <[email protected]>: >>>>> >>>>> >>>>> Hi, >>>>> >>>>> This is the first pull request for "Films For Action" video add-on: >>>>> >>>>> * addon - plugin.video.filmsforaction >>>>> * version - 1.0.0 >>>>> * url - git://github.com/jamontes/plugin.video.filmsforaction.git >>>>> * revision - 689f56439b1d36071b2d8af9707bdb79d4792572 >>>>> * branch - master >>>>> * xbmc version - frodo >>>>> >>>>> >>>>> Changelog (Frodo) >>>>> 1.0.0 >>>>> - Fixed Vimeo custom scraper due to API change. >>>>> - Modified video list parser due to website changes. >>>>> - Added support for SnagFilms videos thanks to the SnagFilms add-on >>>>> (credits: t1m) >>>>> - Updated version number for official repo bump. >>>>> 0.1.0 >>>>> - Remove the Vimeo add-on dependency due to a problem found running on >>>>> Gotham. >>>>> - Made custom Vimeo scraper to support the Vimeo videos on Gotham. >>>>> - Added forum thread to addon and README files. >>>>> 0.0.9 >>>>> - Clean up code and documentation. >>>>> - prepare everything for first bump into git repo. >>>>> >>>>> >>>>> Thanks a lot in advance and best regards, >>>>> >>>>> jamontes. >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Open source business process management suite built on Java and Eclipse >>>>> Turn processes into business applications with Bonita BPM Community >>>>> Edition >>>>> Quickly connect people, data, and systems into organized workflows >>>>> Winner of BOSSIE, CODIE, OW2 and Gartner awards >>>>> http://p.sf.net/sfu/Bonitasoft >>>>> _______________________________________________ >>>>> Xbmc-addons mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
