Updated, thanks! regards, sphere
2014-07-11 11:59 GMT+02:00 Binh Nguyen <[email protected]>: > Thanks sphere, all fixed and new PR below: > > > addon: plugin.video.tvvn > > version: 0.9.3 > url: git://github.com/zecoj/xbmc-tvvn.git > tag: v0.9.3 > xbmc version: frodo/gotham > > > On 11 July 2014 19:02, Tristan Fischer <[email protected]> wrote: >> >> Hi, >> >> there are some issues which need to be fixed before I can accept your PR: >> - No xml encoding specified in >> plugin.video.tvvn/resources/language/English/strings.xml >> - plugin.video.tvvn/tvvn.py: setting PLAYER_CORE_* is deprecated >> >> These issues are not required to fix but suggested: >> - Missing optional forum tag >> - Missing optional source tag >> - Missing optional email tag >> >> >> please fix them and send a new PR. >> >> regards, >> sphere >> >> 2014-07-10 15:31 GMT+02:00 Binh Nguyen <[email protected]>: >> > addon: plugin.video.tvvn >> > >> > version: 0.9.2 >> > url: git://github.com/zecoj/xbmc-tvvn.git >> > tag: v0.9.2 >> > xbmc version: frodo/gotham >> > >> > >> > ------------------------------------------------------------------------------ >> > Open source business process management suite built on Java and Eclipse >> > Turn processes into business applications with Bonita BPM Community >> > Edition >> > Quickly connect people, data, and systems into organized workflows >> > Winner of BOSSIE, CODIE, OW2 and Gartner awards >> > http://p.sf.net/sfu/Bonitasoft >> > _______________________________________________ >> > Xbmc-addons mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> > > > > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > Xbmc-addons mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/xbmc-addons > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
