added. will show up in several hours.
next time please fix the github link and remove the * at the end
regards,
Martijn Kaijser
Team XBMC
On Tue, Jul 22, 2014 at 7:52 PM, Rujinschi Remus <[email protected]> wrote:
>
> *addon - plugin.video.tehnik *version - 2.0.2
> *url - *https://github.com/deltha/plugin.video.tehnik*
> *revision - aa8fc31b1e9ee4e028cb167c632ebf761009ce6a
>
> *branch - master *xbmc version - frodo/gotham
>
> This is a romanian plugin related to the IT and Consumer electronics news
> and trends in Romania. Thank you :)
>
> -------------
>
> History:
> -------------
> On 22/07/2014 20:39:00, Rujinschi Remus wrote:
>
> Hello, Mr. Martijn Kaijser,
>
> The videos are in Romanian.
> I have removed en from the language tag as following:
> from
> <language>en ro</language>
> to
> <language>ro</language>
>
> The version of the addon was changed to v2.0.2.
>
> Thank you,
> Rujinschi Remus
>
>
> ---snipp---
> v2.0.1
> - Using the language atribute in addon.xml
> - Fixing a parse error in
> plugin.video.tehnik/resources/language/English/strings.xml: not
> well-formed (invalid token): line 5, column 27
> - Fixing a parse error in
> plugin.video.tehnik/resources/language/Romanian/strings.xml: not
> well-formed (invalid token): line 5, column 27
>
> v2.0.2
> - Removed en from the language tag from <language>en ro</language> to
> <language>ro</language>
> ---snapp---
>
>
> ---------------------------
>
>
>
>
> On 22/07/2014 09:34:24, Martijn Kaijser wrote:
> are the videos only in Romanian or also English?
> If only Romanian please remove the en from the <language> tag. This is
> used to indicate video language
>
> regards,
> Martijn Kaijser
> Team XBMC
>
>
>
>
> On 15/07/14 17:31, Tristan Fischer wrote:
> Hi,
>
> there are some issues which need to be fixed before I can accept your PR:
> - Parse error in
> plugin.video.tehnik/resources/language/English/strings.xml: not
> well-formed (invalid token): line 5, column 27
> - Parse error in
> plugin.video.tehnik/resources/language/Romanian/strings.xml: not
> well-formed (invalid token): line 5, column 27
>
> Also, if this add-on "only" provides content in a specific language
> you should use the language-attribute in addon.xml for this.
>
> please fix them and send a new PR.
>
> regards,
> sphere
>
>
>
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
