Hi Ronie,
>
>
>I have made all the required changes you mentioned and the skin is now ready 
>for the official repo.
>
>
>*addon skin.BOX
>
>*version 2.6.9
>*url - https://github.com/DjCisco/skin.box
>*revsion  0bc8431e46
>*branch - master
>*xbmc version - gotham
>
> 
>
>Thanks
>
>
>Francisco


On Sunday, October 26, 2014 5:54 PM, ronie <[email protected]> wrote:
 




From: Francisco Flórez <[email protected]>
>Date: 24 October 2014 09:08
>Subject: [Xbmc-addons] [Git Pull] skin.BOX
>To: Xbmc-addons <[email protected]>
>
>
>
>
>
>*addon skin.BOX
>
>*version 2.6.8
>*url - https://github.com/DjCisco/skin.box
>*revsion  9fde044e00
>*branch - master
>*xbmc version - gotham
>
>
>This update is for the skin development repo and for initial inclusion to the 
>official skin repo (the skin has now been fully tested and is ready) 
>thanks
>
>Francisco 
hey Francisco,

thanx for submitting your skin to the official addon repo.

as with all new submissions, i've checked box for any possible
    issues
that needs to be addressed before we can add it to the addon repo.

if you could have a look at these:


skin.box/icon.png 
this file needs to be 256x256 px


skin.box/fanart.jpg
looks like this is actually a png file, renamed to .jpg
please could you fix that


skin.box/debuggrid720.png
skin.box/HomeMenuIcons
skin.box/HomeTileIcons
please move these items into an 'extras' folder.
see: http://kodi.wiki/view/Skin_structure
we try to keep the skin directory structure a bit clean ;-)


_screenshots
looks like these are all actually png files, renamed to .jpg
please could you fix that


media\backgounds\shutdown\shutdown.jpg
looks like this is actually a png file, renamed to .jpg
please could you fix that


media\backgounds\extras\weather_fanart\*
looks like these are all actually png files, renamed to .jpg
please could you fix that


please rename:
colors/Defaults.xml -> colors/default.xml


MusicOSD.xml:                    <onup>-</onup>
MusicOSD.xml:                    <ondown>-</ondown>
please change those actions to 'noop'


the following files start with a BOM, please remove it
./Custom_Overlay.xml
./Custom_HomeWidgetChooser.xml
./Custom_HomeTileTypeChooser.xml
./Custom_HomeCustomization.xml
./Custom_HomeActionChooser.xml
./Custom_HomeIconChooser.xml


there's a space missing between end="90" and center="295,20"
./MyVideoPlaylist.xml:104.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./MyVideoNav.xml:227.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./MyPics.xml:119.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./MyPrograms.xml:82.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru
                
./MyMusicPlaylist.xml:118.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./AddonBrowser.xml:94.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./MyMusicNav.xml:153.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru

./MyMusicSongs.xml:129.25: attributes construct error
            <animation effect="rotate" end="90"center="295,20"
    time="2000" condition="tru


not sure if it is incorrect, but this looks strange to me: '+7' ?
Custom_HomeIconChooser.xml:
<texture
colordiffuse="ImageDiffuse">$INFO[Container(1).ListItem(+7).Thumb]</texture>


Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu
Custom_HomeCustomization.xml: Untranslated Label:Enable Menu


Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon
Includes.xml: Untranslated Label:Menu Icon


VideoOSD.xml:
Untranslated Label:EPG


DialogSubtitles.xml:
Untranslated Label:Local Subtitle Available


SkinSettings.xml:
Untranslated Label:Show Now Playing On Home


remove the default control definition:
DialogKaiToast.xml
<defaultcontrol always="true">402</defaultcontrol>


IncludesHome.xml:
$VAR[SubMenu1Tile1.2ndLabel] is not defined
$VAR[SubMenu2Tile1.2ndLabel] is not defined
$VAR[SubMenu3Tile1.2ndLabel] is not defined
$VAR[SubMenu4Tile1.2ndLabel] is not defined
$VAR[SubMenu5Tile1.2ndLabel] is not defined
$VAR[SubMenu6Tile1.2ndLabel] is not defined
$VAR[SubMenu7Tile1.2ndLabel] is not defined
$VAR[SubMenu8Tile1.2ndLabel] is not defined
$VAR[SubMenu9Tile1.2ndLabel] is not defined
$VAR[SubMenu10Tile1.2ndLabel] is not defined
$VAR[SubMenu11Tile1.2ndLabel] is not defined
$VAR[SubMenu12Tile1.2ndLabel] is not defined
$VAR[SubMenu13Tile1.2ndLabel] is not defined
$VAR[SubMenu14Tile1.2ndLabel] is not defined
$VAR[SubMenu15Tile1.2ndLabel] is not defined


Includes.xml:
$VAR[SubMenu1Tile1Image] is not defined
$VAR[SubMenu2Tile1Image] is not defined
$VAR[SubMenu3Tile1Image] is not defined
$VAR[SubMenu4Tile1Image] is not defined
$VAR[SubMenu5Tile1Image] is not defined
$VAR[SubMenu6Tile1Image] is not defined
$VAR[SubMenu7Tile1Image] is not defined
$VAR[SubMenu8Tile1Image] is not defined
$VAR[SubMenu9Tile1Image] is not defined
$VAR[SubMenu10Tile1Image] is not defined
$VAR[SubMenu11Tile1Image] is not defined
$VAR[SubMenu12Tile1Image] is not defined
$VAR[SubMenu13Tile1Image] is not defined
$VAR[SubMenu14Tile1Image] is not defined
$VAR[SubMenu15Tile1Image] is not defined



if you have any questions, or need help, don't hesitate to ask!

meanwhile, i'll update the version in the skin-dev repo to this.


cheers,
ronie
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to