On 20-01-15 08:39, Cooper Beilby wrote: > Hi Ronie, > > I fixed the majority of these issues. There is no direct access to the > other Radio windows in the skin, but as the home menu is entirely > customisable users can add these windows to the home bar if they so > wish - I would rather not have these as default items unless it is > absolutely non-negotiable regarding repo inclusion. > > All the other issues I have fixed. > > I have (grudgingly) added the missing EPG views; however, preferably I > would rather not include them as I find them unnecessarily confusing > and don't really fit with being "viewtypes" for the EPG. Further, EPG > Now is a double up of MyPVRChannels.xml - and EPG Channels (id13) > shows no info unless something is playing which creates all sorts of > problems. I was under the impression that it was optional for skinners > regarding what views had to be included. Again, if this is > non-negotiable for repo inclusion I will leave them in as I'm not that > interested in debating what is obviously an internal decision, but > otherwise I would rather remove them. > > Let me know if any other changes need to be made. > > * addon - skin.eminence > * version - 1.2.2 > * url - https://github.com/jurialmunkey/skin.eminence > * branch - master > * revision - 5cff7f9cd2e99e62f442dc9e9fb2aad089028767 > * kodi version - helix > > > thnx, > Cooper. >
hey Cooper, i've added Eminence to our Helix repo, thanx for submitting it. as for your questions on the pvr stuff, we're certainly not going to remove your skin from the repo over this. but we'd certainly appreciate it if all guide views are included. imo it might be confusing for users if some functionality is present in one skin and absent in another. generally speaking i don't think it would be wise if each skinner would decide on his own to skip certain parts of Kodi that he finds useless. that being said, i know there are multiple skinners who prefer to drop some of the guide views (you're not the first i had to convince to include them anyway), so if you feel strongly about it, by all means, feel free to bring it up for discussion in the skin dev forum. i'd rather see that we all drop something together than that we all go our separate ways. cheers, ronie ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
