No need to do anything differently. It is only a matter of providing the correct revision. If there was nothing to fix I would have pulled in https://github.com/vonH/skin.xperience1080/commit/c9bd2efa4d0d170bb1b3aee3c6898b94fa74521e
Whereas I am sure you would wanted to have https://github.com/vonH/skin.xperience1080/commit/ec78d88f01dbbb64ca7a7e341879ca673b8d7756 pulled instead. Updated, thx! Rutger On Tue, Sep 29, 2015 at 2:17 PM, PJvH <tonemap...@gmail.com> wrote: > Sure, I submitted it in the way ronie requested and that I have been > doing for over a year. I'll do it differently next time. > > On Tue, Sep 29, 2015 at 1:16 PM, Rutger <big.n...@kodi.tv> wrote: > > You provided the wrong revision indeed. 1d6750c is the commit with the > fixes > > and ad61198 is the commit with the BOM fix. > > I'm going to use ad61198 as revision, okay? > > > > Rutger > > > > On Tue, Sep 29, 2015 at 2:09 PM, PJvH <tonemap...@gmail.com> wrote: > >> > >> changelog.txt correct, 1d6750c > >> > >> On Tue, Sep 29, 2015 at 1:04 PM, PJvH <tonemap...@gmail.com> wrote: > >> > I can't see the HomePictureMultiPath at line 66 - > >> > > >> > > https://github.com/vonH/skin.xperience1080/commit/699c12d98e4ccb3bfc59c0db881827e1b28dfde1 > >> > It's not there, maybe I provided the wrong revision? Can you please > >> > confirm - I've also checked with phil's ST3Kodi plugin, it's not > >> > there. > >> > > >> > Will fix the BOM issue. > >> > > >> > On Tue, Sep 29, 2015 at 1:01 PM, Rutger <big.n...@kodi.tv> wrote: > >> >> Hi Piers, > >> >> > >> >> This one is still there: > >> >> Variable not defined: HomePicturesMultiPath > >> >> 1080i/Includes_Home.xml: line 66 > >> >> > >> >> And I missed one in previous check: > >> >> Files with BOM: > >> >> changelog.txt > >> >> > >> >> Rutger > >> >> > >> >> > >> >> > >> >> > >> >> On Tue, Sep 29, 2015 at 11:43 AM, PJvH <tonemap...@gmail.com> wrote: > >> >>> > >> >>> Issued should be resolved. > >> >>> > >> >>> addon - skin.xperience1080 > >> >>> version - 4.2.0 > >> >>> url - https://github.com/vonH/Xperience1080 > >> >>> revision - ec78d88 > >> >>> branch - Isengard > >> >>> xbmc version - 15 > >> >>> > >> >>> On Tue, Sep 29, 2015 at 10:27 AM, Rutger <big.n...@kodi.tv> wrote: > >> >>> > Hi Piers, > >> >>> > > >> >>> > Please check the following errors that came up: > >> >>> > Variable not defined: HomePicturesMultiPath > >> >>> > 1080i/Includes_Home.xml: line 66 > >> >>> > > >> >>> > Include not defined: HomeWidget.7.Photos > >> >>> > 1080i/Includes_HomeWidgets.xml: line 121 > >> >>> > > >> >>> > Include not defined: FullScreenDimensions > >> >>> > 1080i/script-videoextras-main.xml: line 9 > >> >>> > > >> >>> > Rutger > >> >>> > > >> >>> > On Tue, Sep 29, 2015 at 7:52 AM, PJvH <tonemap...@gmail.com> > wrote: > >> >>> >> > >> >>> >> addon - skin.xperience1080 > >> >>> >> version - 4.2.0 > >> >>> >> url - https://github.com/vonH/Xperience1080 > >> >>> >> revision - c9bd2ef > >> >>> >> branch - Isengard > >> >>> >> xbmc version - 15 > >> >>> >> > >> >>> >> Cheers, > >> >>> >> > >> >>> >> Piers > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> > ------------------------------------------------------------------------------ > >> >>> >> _______________________________________________ > >> >>> >> Xbmc-addons mailing list > >> >>> >> Xbmc-addons@lists.sourceforge.net > >> >>> >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons > >> >>> > > >> >>> > > >> >> > >> >> > > > > >
------------------------------------------------------------------------------
_______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
