Hi ronie,
Change done.

*addon - plugin.onedrive
*version - 1.0.4
*url -https://github.com/cguZZman/k-onedrive.git
*revision - a3c5a25483816fa35f3aa1266fbfccbbef14b9e0
*branch - master
*xbmc version - Helix and Isengard

Let me know if anything else is needed.

Thanks,
Carlos


On 10/18/2015 6:09 AM, ronie wrote:
On 18-10-15 06:57, Carlos Guzman wrote:
*addon - plugin.onedrive
*version - 1.0.3
*url -https://github.com/cguZZman/k-onedrive.git
*revision - 61fc590d81a2b49482b7ec9e2300faab35551c75
*branch - master
*xbmc version - Helix and Isengard

Thanks!


hey Carlos,

thanx for submitting your addon to our repo!

i've had a look at your code and have one request:
/config_path //=//xbmc.translatePath(//'special://home/onedrive.ini'//)/
please don't store anything in 'special://home/'.
if all addons would do that, that folder will become a giant mess :-)

each addon can store it's data in their own ../userdata/addon_data/addon.id/ folder,
so could you please change it to that?

cheers,
ronie

------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to