Hi,

I fixed all problems latest commit is
38eb5084fd29606efbbd6cd51bcc8b769c7cad95

Regards,
Jordan

On 19 October 2015 at 23:24, ronie <ro...@kodi.tv> wrote:

> On 19-10-15 08:12, Jordan Vichev wrote:
> > Hi,
> >
> > We have contracts with channels providers to broadcast them abroad.
> >
> > Regards,
> > Jordan
> >
>
> hey Jordan,
>
> great, thanx for the confirmation!
>
> i've reviewed your code and there's a couple of things that need your
> attention.
>
> in your addon.xml, please use version="2.0.0", we only support a x.y.z
> version scheme for addons.
>
> it's not needed to include pyxbmct and requests in your addon.
> you should add them as a dependency in your addon.xml and they will be
> installed automatacally from our addon repo.
> (you've already done this for the requests library).
>
>
> is the ../resources/xbmc-logo.png file used anywhere in your addon?
> if so, please replace it with a kodi logo, otherwise please remove it.
>
>
> in your addon.py file:
> __addon_name__ = 'MyTV.BG'
> __id__ = 'plugin.video.mytv_bg'pyxbmct
> please don't hardcode names and id's, simply use:
> __addon_name__ = xbmcaddon.Addon().getAddonInfo('name')
> __id__ = xbmcaddon.Addon().getAddonInfo('id')
>
> please don't hardcode text that is going to be shown in the skin.
> all the text you pass to the ok dialog needs to be put in the language file
> so it can be translated to other languages.
>
>
> cheers,
> ronie
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Xbmc-addons mailing list
> Xbmc-addons@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to