On 28-10-15 11:49, Jesse Lord wrote: > *addon - script.tag-generator > *version - 0.4 > *url - https://github.com/wellspokenman/tag-generator.git > *revision - dd3b595 > *branch - master > *xbmc version - helix
hey Jesse, thanx for submitting your addon to the repo! i've had a look at the addon and there's a couple of things that could be improved... addon.xml: - please change the version to 0.0.4, our repo only supports a x.y.z versioning scheme - library="main.py" start="[login]"> this is incorrect, it should be: start="login" - <summary>IMDB and Stand-up Tag Generator</summary> please add a lang attribute, eg: <summary lang="en"> icon.png: - please use a solid background instead of a transparent one, see: http://kodi.wiki/view/Add-on_structure#icon.png settings.xml: - <category label=Settings> should be: <category label="Settings"> - please don't use hardcoded labels in settings, instead move all of them to a language file, so pleople can translate them to different languages main.py: - again, don't use hardcoded strings in your code, everything must be done through a language file - don't use print statement, instead use xbmc.log() with the xbmc.LOGDEBUG level - __settings__ = xbmcaddon.Addon(id="script.tag-generator") don't hardcode the addonid, simply use: __settings__ = xbmcaddon.Addon() kodi will resolve the addonid automatically last, but not least.. the addon crashes on my end: 12:08:26 T:140275015988992 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<-- - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <class 'urllib2.HTTPError'> Error Contents: HTTP Error 404: Not Found Traceback (most recent call last): File "/home/ronie/.kodi/addons/tag-generator/main.py", line 457, in <module> imdblist = scrapeimdbrss(imdburl, scrapecount) File "/home/ronie/.kodi/addons/tag-generator/main.py", line 224, in scrapeimdbrss infile = opener.open(imdburl) File "/usr/lib/python2.7/urllib2.py", line 437, in open response = meth(req, response) File "/usr/lib/python2.7/urllib2.py", line 550, in http_response 'http', request, response, code, msg, hdrs) File "/usr/lib/python2.7/urllib2.py", line 475, in error return self._call_chain(*args) File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain result = func(*args) File "/usr/lib/python2.7/urllib2.py", line 558, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 404: Not Found -->End of Python script error report<-- if you have any questions, or need any help, don't hesitate to ask :-) cheers, ronie ------------------------------------------------------------------------------ _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
