On 30-01-16 12:06, Tomer Meirov wrote:
*addon - skin.phenomenal
*version - 1.5.1
*url
-https://drive.google.com/file/d/0B8R_P390IQPOa1FraW41clJNUDA/view?usp=sharing
*xbmc version - isengard
since is my first time I'm sending skin to the official repository, I'm sending a Zip
file via Google Drive, but I do have github hosting for my skin, and you can find it
here:https://github.com/tomer953/skin.phenomenal - only different from the zip file, is
that currently in the github I have "Textures.xbt" file in the media folder and
not uncompressed files.
hey Tomer,
thanx for submitting your skin to the addon repo!
we're always excited to welcome new skins to our repository.
very interesting to see a skin designed by someone with a RTL script
background :-)
as with all new skins, the first pull-request is gonna take a bit of
effort to get everything into shape for our repo.
but when the initial hurdles have been taken, subsequent pull-request
should go easy as a breeze.
i've had a look at phenominal and gathered a few things that require
your attention:
- make sure the licence.txt and the licence tag in addon.xml match
(CC BY-NC-SA vs. CC BY-SA)
- remove these files
backgrounds/Thumbs.db
backgrounds/weather/Thumbs.db
backgrounds/weather/2/Thumbs.db
backgrounds/weather/27/Thumbs.db
backgrounds/weather/30/Thumbs.db
extras/Thumbs.db
extras/busy/Thumbs.db
extras/icons/Thumbs.db
media/Thumbs.db
media/audio/Thumbs.db
media/calibrate/Thumbs.db
media/colors/Thumbs.db
media/dialogs/Thumbs.db
media/flags/Thumbs.db
media/flags/subs/Thumbs.db
media/main/Thumbs.db
media/osd/Thumbs.db
media/weather_/Thumbs.db
- Custom_Overlay.xml
window id needs to be in the 11xx range (id 50 is used by the eventlog
window)
- all files need to have unix style eol's (LF), please fix these files:
changelog.txt: Windows (CRLF)
extras/views.xml: Windows (CRLF)
1080p/*.xml: Mixed, predominantly Windows (CRLF)
- undefined Includes:
Includes_Home.xml: HomeInfoAnimation
- unmatched brackets:
Includes.xml: !IsEmpty(Player.Art(tvshow.poster) +
IsEmpty(Player.Art(poster)) + IsEmpty(Player.Art(clearlogo))
Includes.xml: !IsEmpty(Player.Art(thumb)) +
IsEmpty(Player.Art(clearlogo)) + IsEmpty(Player.Art(poster)) +
IsEmpty(Player.Art(tvshow.poster)
- undefined id's (5040):
Includes_Home.xml
Includes_Animations.xml
untranslated labels:
Includes.xml: bit
Includes.xml: Bitrate
Includes.xml: Channels
- DialogSeekBar.xml
typo in the windowclose animation: WindosClose
- DialogExtendedProgressBar.xml
remove the visible checks for karaokeselector and karaokelargeselector,
these don't exists anymore
- MyVideoNav.xml
invert this condition:
<onload
condition="!Skin.HasSetting(NextAired)">RunScript(script.tv.show.next.aired,backend=True)</onload>
- Home.xml
everytime i go to the home window, this error is logged:
19:25:23 T:139794779113600 ERROR: Control 9000 in window 10000 has
been asked to focus, but it can't
in case you need help, or have any questions about the items above,
don't hesitate to ask!
cheers,
ronie
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
