Thank you for your kind help.

Everything has been fixed as you asked except the script.featherence.service – 
which I cannot remove since the skin require it.

 

*addon – skin.featherence

*version – 0.4.4
*url - https://github.com/finalmakerr/featherence_skin/

*revision – master branch - latest
*xbmc version –isengard

 

 

 

 

From: ronie [mailto:ro...@kodi.tv] 
Sent: Friday, February 19, 2016 2:30 AM
To: finalmak...@gmail.com; xbmc-addons@lists.sourceforge.net
Subject: Re: [Xbmc-addons] [Git Pull] skin.featherence

 

On 18-02-16 10:18, finalmak...@gmail.com wrote:

Hey Ronie,

 

Here is a new github repo with the skin only.

 

*addon – skin.featherence

*version – 0.4.4
*url - https://github.com/finalmakerr/featherence_skin/

*revision – master branch - latest
*xbmc version –isengard


hey finalmakerr,


as with all new skins that are being submitted to the repo, there are some 
things that need to be fixed before the skin is ready to be pulled in to our 
repository.
it may even take a couple of rounds to get everything into shape.

i had a look at featherence and came up with a list of things that needs to be 
adressed:


- addon.xml
script.featherence.service is not available in our repo
fill in the summary field


- icon.png
needs to be 256x256 px


- fanart.jpg
needs to be a jpeg file, not a png with a .jpg extension


- language/English/strings.po
all the msgstr fields needs to be empty in the english language file
skins can only use string id's in the 31xxx range
lots of lines are missing the closing quotes, ie: msgctxt "#31098


- remove this file (media folder may only contain images):
media/buttons/colors/colors.xml


- move this to the root of your skin (and rename it to 
LICENSE-country-flags.txt or something...)
media/badges/countries/LICENSE.txt


- invalid xml
1080i/Includes_DialogMenuContent.xml line 713: missing space between button and 
id
1080i/Includes_LeftMenu.xml line 424: use & instead of &
1080i/Includes_Variables.xml line 284: use & instead of &
1080i/Includes_Genre.xml multiple lines: use & instead of & - 48 J
1080i/SlideShow.xml line 231: remove this line


- 1080i/DialogSeekBar
file starts with a BOM character, please remove it


- undefined includes
1080i/SettingsCategory.xml: <include 
condition="Skin.HasSetting(Performance)">Slide1p</include>
1080i/SettingsCategory.xml: <include 
condition="Skin.HasSetting(Performance)">Slide2p</include>
1080i/MyMusicPlaylistEditor.xml: <include>HeadingL</include>
1080i/SettingsProfile.xml: <include>Heading</include>
1080i/SettingsSystemInfo.xml: <include>Heading</include>
1080i/SmartPlaylistEditor.xml: <include>Heading</include>
1080i/Includes_Widget.xml: <include>WidgetContent_54</include>
1080i/Includes_Widget.xml: <include>WidgetContent_53</include>
1080i/Includes_Widget.xml: <include>SubContent_321</include>
1080i/Includes_CenterMenu.xml: <include description="בחירת קבצים" 
condition="true">CenterMenuContent_FileBrowser</include>


- undefined variables
1080i/DialogAlbumInfo.xml: <bordertexture 
colordiffuse="$VAR[main_color]">white.png</bordertexture>
1080i/DialogAlbumInfo.xml: <textcolor>$VAR[main_color]</textcolor>
1080i/DialogSeekBar.xml: <label>$INFO[VideoPlayer.VideoResolution,, | 
]$INFO[VideoPlayer.VideoCodec,, | ]$INFO[VideoPlayer.AudioCodec,, | 
]$VAR[AudioChannelVar,, | ]$INFO[VideoPlayer.VideoAspect]</label>
1080i/Includes_Views.xml: <texture 
colordiffuse="$VAR[IconUמFocusColor]">$VAR[Overlay2]</texture>
1080i/Includes_DialogMenuContent.xml: <param name="color" 
value="$VAR[ButtonUמFocusColor]" />


- unmatched parenthesis
Includes_Variables_label2.xml: <value 
condition="Skin.String(MainBackgroundTexture">MainBackgroundTexture</value>
Includes_CenterMenuContent.xml: <onclick description="1139-DOWN" 
condition="Window.IsVisible(Custom1139.xml) + 
!IsEmpty(Window(home).Property(Next_SubButton.ID_)) + 
!SubString(Window(home).Property(Next_SubButton.ID_,_90)">RunScript(script.featherence.service,,?mode=210&amp;value=2)</onclick>
Includes_CenterMenuContent.xml: <onclick description="1139-UP" 
condition="Window.IsVisible(Custom1139.xml) + 
!IsEmpty(Window(home).Property(Previous_SubButton.ID_)) + 
!SubString(Window(home).Property(Previous_SubButton.ID_,_90)">RunScript(script.featherence.service,,?mode=210&amp;value=1)</onclick>


- undefined id 313
Includes_Small.xml: <onleft condition="Control.HasFocus(313)">313</onleft>
Includes_Small.xml: <onright condition="Control.HasFocus(313)">313</onright>
Includes_Widget.xml: <animation condition="!Container(313).Scrolling + 
Skin.HasSetting(background)" effect="fade" start="40" 
end="40">Conditonal</animation>
Includes_Widget.xml: <animation condition="!Container(313).Scrolling + 
!Skin.HasSetting(background)" effect="fade" start="40" 
end="40">Conditonal</animation> 
Includes.xml: <visible>!Control.HasFocus(311) + !Control.HasFocus(312) + 
!Control.HasFocus(313) + !Control.HasFocus(314) + 
!Control.HasFocus(315)</visible>


- undefined id 314
Includes_Small.xml: <onleft condition="Control.HasFocus(314)">314</onleft>
Includes_Small.xml: <onright condition="Control.HasFocus(314)">314</onright> 
Includes.xml: <visible>!Control.HasFocus(311) + !Control.HasFocus(312) + 
!Control.HasFocus(313) + !Control.HasFocus(314) + 
!Control.HasFocus(315)</visible>


- undefined id 315
Includes_Small.xml: <onleft condition="Control.HasFocus(315)">315</onleft>
Includes_Small.xml: <onright condition="Control.HasFocus(315)">315</onright>
Includes.xml: <visible>!Control.HasFocus(311) + !Control.HasFocus(312) + 
!Control.HasFocus(313) + !Control.HasFocus(314) + 
!Control.HasFocus(315)</visible>


- undefined id 3200
Includes_Small.xml: <animation description="Slide_en" 
condition="!StringCompare(System.Language,Hebrew) + Control.IsVisible(3200)" 
effect="slide" start="0,0" end="90,0">Conditonal</animation>
Includes_Small.xml: <animation description="Slide_en" 
condition="!StringCompare(System.Language,Hebrew) + Control.IsVisible(3200)" 
effect="slide" start="0,0" end="90,0">Conditonal</animation>
Includes.xml: <animation description="Slide_en" 
condition="!StringCompare(System.Language,Hebrew) + !Control.IsVisible(3200)" 
effect="slide" start="0,0" end="-90,0">Conditonal</animation>
Includes.xml: <animation description="Slide_en" 
condition="!StringCompare(System.Language,Hebrew) + Control.IsVisible(3200)" 
effect="slide" start="0,0" end="90,0">Conditonal</animation>


- undefined id 9003
Includes_LeftMenu.xml: <visible>!Control.IsVisible(9003)</visible>
Includes_LeftMenu.xml: <visible>!Control.IsVisible(9003)</visible>
Includes_LeftMenu.xml: <visible>!Control.IsVisible(9003)</visible>


- undefined id 340
Includes_Widget.xml: <visible description="לא כפתור 
סרטים/סדרות">!Container(9000).HasFocus(340) + !Container(9000).HasFocus(341) + 
!Container(50).HasFocus(340) + !Container(50).HasFocus(341)</visible>


- undefined id 310
Includes_Small.xml: <onup condition="Window.IsVisible(CustomHomeCustomizer.xml) 
+ Control.IsVisible(310) + !Control.IsVisible(7011)">310</onup>


- missing string id
Includes_LeftMenu.xml: $LOCALIZE[]


- untranslated labels
Includes_LeftMenu.xml: Views Settings
Includes_LeftMenu.xml: Views Settings
Includes_LeftMenu.xml: Hide broken addons
Includes_LeftMenu.xml: Number of items in the playlist
Includes_LeftMenu.xml: מנהל ערוצים
Includes_LeftMenu.xml: AutoView Settings
Includes_LeftMenu.xml: Views Settings
Includes_LeftMenu.xml: Toggle
Includes_CenterMenuContent.xml: Similar button
Includes_HomeContent.xml: Test
Includes_HomeContent.xml: REFRESH BUTTONS
FileBrowser.xml: Horizontal Flip
Custom1170.xml: Info
DialogKeyboard.xml: Options
DialogKeyboard.xml: Symbols
Custom1000.xml: If value keep changing, your device is not stuck!
Includes_SettingsContent.xml: ביצועים
Includes_SettingsContent.xml: מתקדם



in case you have any questions on the items above, just let me know.


cheers,
ronie

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to