On 21-02-16 09:49, finalmak...@gmail.com wrote:
Hey Ronie,
Following my pull request for skin.featherence:
**addon* β script.featherence.service
**version* β 0.2.2
**url* -
https://github.com/finalmakerr/featherence/tree/master/master/script.featherence.service
**revision* β master branch - latest
**xbmc version* βAll
After this addon is settle down I will make 5 more pull requests J.
hey finalmakerr,
i've had a look at the script and came up with this list of issues that
requires fixing:
- resources/language/English/strings.po
all the msgstr fields needs to be empty in the english language file
skins can only use string id's in the 32xxx range
lots of lines are missing the closing quotes, ie: msgctxt "#31098
- you need to localize all the text in your script that gets displayed
in the notification / yesno dialogs
- executing all kinds of shell scripts is not allowed in our repo
if Remote_Name != "None": os.system('sh
/storage/.kodi/addons/script.htpt.remote/remote.sh')
if systemplatformandroid: terminal('am start -a
android.intent.action.MAIN -n com.android.settings/.Settings',name)
elif systemplatformwindows: terminal('rundll32.exe van.dll,RunVAN',name)
if systemplatformwindows: terminal('start /max '+url+'','')
elif systemplatformandroid: terminal('adb shell am start -a
android.intent.action.VIEW -d '+url+'','')
- remove support for addons that are not in the official kodi repo, for
instance:
plugin://plugin.video.wallaNew.video
plugin://plugin.video.hotVOD.video
plugin://plugin.video.sdarot.tv
plugin://plugin.video.gdrive
- i don't think these are legit sites, look more like pirated content to me:
http://www.moridim.tv/
http://dragonballz.co.il/
http://www.supercartoons.net/
http://serethd.net/
http://www.sdarot.pm/
- downloading suff from dropbox (or other file sharing sites) is not
allowed in our repo
def DownloadFile(url, filename, downloadpath, extractpath, silent=False,
percentinfo=""):
name = 'DownloadFile' ; printpoint = "" ; TypeError = "" ; extra =
"" ; returned = ""
downloadpath2 = os.path.join(downloadpath, filename)
if 'https://www.dropbox.com/s//' in url: printpoint = printpoint + '9'
- this is not the way to install official addons. add them as a
dependency to your script or skin instead.
DownloadFile("https://github.com/XBMC-Addons/resource.images.weathericons.outline/archive/master.zip";,
addon + ".zip", packages_path, addons_path, silent=True)
cheers,
ronie
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
