On 09-04-16 02:03, Bryan Brazil wrote:
*addon - skin.mimic
*version - 4.0.0
*url - _https://github.com/bryanbrazil/skin.mimic.git_
*revision - a4b0ea1a8a948efd5f8c1aaa9eefe903e1c0e928
*branch - master
*xbmc version - krypton
*addon - skin.mimic
*version - 3.4.1
*url - _https://github.com/bryanbrazil/skin.mimic.git_
*revision - e02f5628bf40e337a80d905caf0c497ca6c8efee
*branch - jarvis
*xbmc version - jarvis
This is my first submission of Mimic for Kodi 17 Krypton. The second
request is an update for the Jarvis version of the skin. You can
disregard the previous pull request I sent on March 28, I don't think
it got reviewed.
Thanks!
hey Bryan,
your previous pr didn't make it to my inbox for some reason...
feel free to ping me whenever a pull request isn't processed within one
week.
here's a few issues i came across when checking the code:
Krypton:
script-ExtendedInfo Script-DialogVideoInfo.xml - Unmatched parenthesis:
!String.IsEmpty(Window.Property(SubtitleLanguage.1)
Jarvis:
script-ExtendedInfo Script-DialogVideoInfo.xml - Unmatched parenthesis:
!IsEmpty(Window.Property(SubtitleLanguage.1)
custom_1119_ExtrasDialog.xml - Undefined IDs:
90209
90210
90212
cheers,
ronie
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/
gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
