Hi Ronie Thanks!
[DONE] - please remove this file: media/media.zip [DONE] - remove the reference to View_VideoRecentItems.xml / View_MusicRecentItems.xml from Includes.xml. those files don't exist [FIXED] - Defaults.xml: <texturesliderbar>colors/inactive.png</texturesliderbar> but that texture is missing in the media folder [FIXED] - the song info dialog does not seem to work - the musicosd dialog does not work either? It's there, just implemented in a slightly different way. Player controls are accessed by pressing select on the fullscreen music view. - too many homescreen backgrounds :-) Point taken! I've replaced the selection with ~10 images that are all sourced from Flickr + are marked as public domain. Updated pull: *addon - skin.pellucid *version - 1.0.0 *url - https://github.com/chrisbevan/skin.pellucid *revision - 283e67a7c2a86d76815957e551ea1ce916f0518b *branch - Krypton *xbmc version - Krypton Thanks again, Chris. On Sun, Dec 4, 2016 at 11:26 PM, ronie <ro...@kodi.tv> wrote: > On 30-11-16 20:49, Chris Bevan wrote: >> >> Hi there. I'd like to have this skin considered for the Krypton >> repo please. >> >> *addon - skin.pellucid >> *version - 1.0.0 >> *url - https://github.com/chrisbevan/skin.pellucid >> *revision - 2889bf7d8c6ff77606ec3a9f24db42eebb900925 >> *branch - Krypton >> *xbmc version - Krypton >> >> Cheers! >> Chris. > > > hey Chris, > > thanx a bunch for submitting your skin to the repo! > always exiting to see a fresh skin popping up on our doorsteps :-) > > as with all new skins, it might take a bit of effort to get it into shape > for repo inclusion... > > i've gone through the code and came up with a short list of things that > would require some attention: > - please remove this file: media/media.zip > - remove the reference to View_VideoRecentItems.xml / > View_MusicRecentItems.xml from Includes.xml. those files don't exist > - Defaults.xml: <texturesliderbar>colors/inactive.png</texturesliderbar> but > that texture is missing in the media folder > - the song info dialog does not seem to work > - the musicosd dialog does not work either? > > lastly, the number of images in extras/homeBackgrounds worries me a bit. > i wouldn't mind if you ship with ~10 different home backgrounds, but 100+ of > them is a bit too much :-) > perhaps you can submit them seperatly, as a resource addon? > > if you do, please make sure all images have a license that allows > redistribution. > a sampled a few of them, and it least > extras/homeBackgrounds/1080_untouched.jpg does not seem to qualify > (http://www.sciway.net/sc-photos/charleston-county/botany-bay.html) > > > if you have any questions, or need help, please just ask! > > > cheers, > ronie > > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
